-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release v2.3.0-mainnet #660
Conversation
Signed-off-by: Riccardo Montagnin <[email protected]>
Signed-off-by: Riccardo Montagnin <[email protected]>
Signed-off-by: Riccardo Montagnin <[email protected]>
Signed-off-by: Riccardo Montagnin <[email protected]>
Signed-off-by: Riccardo Montagnin <[email protected]>
Signed-off-by: Riccardo Montagnin <[email protected]>
Signed-off-by: Riccardo Montagnin <[email protected]>
…abs/desmos into riccardo/release/v2.1.0-mainnet � Conflicts: � .github/workflows/on-chain-upgrade.yml � app/app.go
…release/v2.1.0-mainnet � Conflicts: � .github/workflows/on-chain-upgrade.yml � app/app.go � contrib/upgrade_testnet/docker-compose.yml � x/profiles/legacy/v210/store.go
Signed-off-by: Riccardo Montagnin <[email protected]>
GENESIS_DESMOS_VERSION: "v1.0.1" | ||
GENESIS_URL: "https://raw.githubusercontent.com/RiccardoM/desmos-states/master/desmos-mainnet-780000.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to match the current mainnet data
@@ -63,7 +63,7 @@ sleep 6s | |||
|
|||
echo "" | |||
echo "===> Getting proposal id" | |||
PROPOSAL_ID=$(desmos q tx $TX_HASH --output json 2>&1 | jq .logs[0].events[4].attributes[0].value -r) | |||
PROPOSAL_ID=$(desmos q tx $TX_HASH --output json 2>&1 | jq .logs[0].events[2].attributes[0].value -r) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert the changes to match Cosmos v0.42 events list
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
==========================================
- Coverage 15.78% 15.77% -0.01%
==========================================
Files 169 169
Lines 46009 46033 +24
==========================================
Hits 7263 7263
- Misses 38119 38143 +24
Partials 627 627
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to approve this.
…release/v2.1.0-mainnet � Conflicts: � .github/workflows/on-chain-upgrade.yml � app/app.go
@RiccardoM I've solved the conflicts. Please take a look whenever you can. It should be the correct configuration since this is the first on-chain auto-upgrade of the mainnet/. |
@RiccardoM done |
@RiccardoM looking at this I've seen that we need to hardcode the |
That is not correct. The When the upgrade height comes, what happens is the following:
If the current version is
And this is why inside the |
Description
This PR implements the changes needed in order to tag
v2.1.0-mainnet
of Desmos. Refer to #657 for major details.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change