Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v2.3.0-mainnet #660

Merged
merged 15 commits into from
Nov 10, 2021
Merged

Conversation

RiccardoM
Copy link
Contributor

Description

This PR implements the changes needed in order to tag v2.1.0-mainnet of Desmos. Refer to #657 for major details.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Signed-off-by: Riccardo Montagnin <[email protected]>
Signed-off-by: Riccardo Montagnin <[email protected]>
Signed-off-by: Riccardo Montagnin <[email protected]>
Signed-off-by: Riccardo Montagnin <[email protected]>
Signed-off-by: Riccardo Montagnin <[email protected]>
…abs/desmos into riccardo/release/v2.1.0-mainnet

� Conflicts:
�	.github/workflows/on-chain-upgrade.yml
�	app/app.go
…release/v2.1.0-mainnet

� Conflicts:
�	.github/workflows/on-chain-upgrade.yml
�	app/app.go
�	contrib/upgrade_testnet/docker-compose.yml
�	x/profiles/legacy/v210/store.go
@RiccardoM RiccardoM added the requires-upgrade Test the on-chain upgrade for this PR label Oct 26, 2021
@github-actions github-actions bot added the kind/ci Improve the CI/CD label Oct 26, 2021
Comment on lines +25 to +26
GENESIS_DESMOS_VERSION: "v1.0.1"
GENESIS_URL: "https://raw.githubusercontent.com/RiccardoM/desmos-states/master/desmos-mainnet-780000.json"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to match the current mainnet data

app/app.go Show resolved Hide resolved
app/app.go Show resolved Hide resolved
contrib/upgrade_testnet/docker-compose.yml Show resolved Hide resolved
@@ -63,7 +63,7 @@ sleep 6s

echo ""
echo "===> Getting proposal id"
PROPOSAL_ID=$(desmos q tx $TX_HASH --output json 2>&1 | jq .logs[0].events[4].attributes[0].value -r)
PROPOSAL_ID=$(desmos q tx $TX_HASH --output json 2>&1 | jq .logs[0].events[2].attributes[0].value -r)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the changes to match Cosmos v0.42 events list

@RiccardoM RiccardoM requested review from leobragaz and dadamu October 26, 2021 06:02
@RiccardoM RiccardoM changed the title choire: release v2.1.0-mainnet chore: release v2.1.0-mainnet Oct 26, 2021
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #660 (a47566b) into master (581744d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
- Coverage   15.78%   15.77%   -0.01%     
==========================================
  Files         169      169              
  Lines       46009    46033      +24     
==========================================
  Hits         7263     7263              
- Misses      38119    38143      +24     
  Partials      627      627              
Impacted Files Coverage Δ
app/app.go 77.88% <0.00%> (-4.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 581744d...a47566b. Read the comment docs.

Copy link
Contributor

@dadamu dadamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready

@RiccardoM RiccardoM added the status/on-hold This issue is temporarily suspended label Oct 26, 2021
Copy link
Contributor

@leobragaz leobragaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to approve this.

…release/v2.1.0-mainnet

� Conflicts:
�	.github/workflows/on-chain-upgrade.yml
�	app/app.go
@leobragaz
Copy link
Contributor

@RiccardoM I've solved the conflicts. Please take a look whenever you can. It should be the correct configuration since this is the first on-chain auto-upgrade of the mainnet/.

@RiccardoM RiccardoM changed the title chore: release v2.1.0-mainnet chore: release v2.3.0-mainnet Nov 9, 2021
app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
@leobragaz
Copy link
Contributor

@RiccardoM done

@RiccardoM RiccardoM removed the status/on-hold This issue is temporarily suspended label Nov 9, 2021
@leobragaz
Copy link
Contributor

@RiccardoM looking at this I've seen that we need to hardcode the ConseusVersion to 1 the first time.
Currently it's set to 3. We should change it, confirm?

@RiccardoM
Copy link
Contributor Author

@RiccardoM looking at this I've seen that we need to hardcode the ConseusVersion to 1 the first time. Currently it's set to 3. We should change it, confirm?

That is not correct. The ConsensusVersion identifies the latest version of a module. In our case, the x/profiles module should be at its third version (ConsensusVersion = 3) due to 2 previous migrations we had to run.

When the upgrade height comes, what happens is the following:

  • the current veision of each module is read using the fromVm map
  • the updated version of each module is read using the ConsensusVersion method
  • for each module, we perform an upgrade old_version -> current_version

If the current version is 1 and the new one is 3, then two upgrades are performed:

  1. From 1 to 2
  2. From 2 to 3

And this is why inside the x/profiles migrator we have two methods: Migrate1To2 and Migrate2To3

@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Nov 10, 2021
@mergify mergify bot merged commit 90aa668 into master Nov 10, 2021
@mergify mergify bot deleted the riccardo/release/v2.1.0-mainnet branch November 10, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass kind/ci Improve the CI/CD requires-upgrade Test the on-chain upgrade for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants