Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v2.0.0 upgrade #629

Merged
merged 8 commits into from
Sep 27, 2021
Merged

feat: v2.0.0 upgrade #629

merged 8 commits into from
Sep 27, 2021

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Sep 22, 2021

Description

Adds the on-chain upgrade handler for the upcoming version 2.0 of Desmos


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added kind/ci Improve the CI/CD x/CLI x/profiles Module that allows to create and manage decentralized social profiles labels Sep 22, 2021
@RiccardoM RiccardoM added requires-upgrade Test the on-chain upgrade for this PR and removed requires-upgrade Test the on-chain upgrade for this PR labels Sep 22, 2021
@RiccardoM RiccardoM changed the title !feat: v2.0.0 upgrade feat: v2.0.0 upgrade Sep 22, 2021
@RiccardoM RiccardoM added the requires-upgrade Test the on-chain upgrade for this PR label Sep 22, 2021
Signed-off-by: Riccardo Montagnin <[email protected]>
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #629 (a08f49b) into master (1a22342) will decrease coverage by 0.44%.
The diff coverage is 12.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
- Coverage   84.23%   83.79%   -0.45%     
==========================================
  Files          91       91              
  Lines        6624     6663      +39     
==========================================
+ Hits         5580     5583       +3     
- Misses        833      866      +33     
- Partials      211      214       +3     
Impacted Files Coverage Δ
app/app.go 77.70% <12.19%> (-6.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a22342...a08f49b. Read the comment docs.

Signed-off-by: Riccardo Montagnin <[email protected]>
@github-actions github-actions bot removed the x/CLI label Sep 22, 2021
Copy link
Contributor

@dadamu dadamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is great to me. 👍

@RiccardoM RiccardoM merged commit d6e42b6 into master Sep 27, 2021
@RiccardoM RiccardoM deleted the riccardo/v2.0.0-upgrade branch September 27, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/ci Improve the CI/CD requires-upgrade Test the on-chain upgrade for this PR x/profiles Module that allows to create and manage decentralized social profiles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants