Oracle params improvement #547

dadamu · 2021-07-08T10:16:39Z

Description

This PR is the implementation of #537. It moves oracle params to on-chain store, instead of hard coded.
Closes #537

Checklist

Targeted PR against correct branch.
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Wrote unit tests.
Wrote integration tests (simulation & CLI).
Updated the documentation.
Added an entry to the CHANGELOG.md file.
Re-reviewed Files changed in the Github PR explorer.

codecov · 2021-07-08T11:23:42Z

Codecov Report

Merging #547 (8e6a99c) into master (5378bac) will increase coverage by 0.15%.
The diff coverage is 89.09%.

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
+ Coverage   82.69%   82.84%   +0.15%     
==========================================
  Files          91       91              
  Lines        5431     5468      +37     
==========================================
+ Hits         4491     4530      +39     
+ Misses        738      736       -2     
  Partials      202      202

Impacted Files	Coverage Δ
x/profiles/types/models_params.go	`85.59% <86.66%> (+3.54%)`	⬆️
x/profiles/keeper/relay_app_links.go	`95.38% <100.00%> (+0.07%)`	⬆️
app/app.go	`82.26% <0.00%> (+1.43%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5378bac...8e6a99c. Read the comment docs.

…le-params-improvement

x/profiles/types/models_params.go

x/oracle/types/constants.go

…le-params-improvement

x/profiles/types/models_params.go

RiccardoM

invalid oracle params return no error should be invalid oracle params return error

RiccardoM

We should add the oracle params validation inside the ValidateGenesis function

dadamu · 2021-07-12T07:50:03Z

@RiccardoM Oracle params validation is in the Params.Validate() function which is also called by ValidateGenesis function.

x/profiles/types/models_params.go

x/profiles/simulation/utils.go

proto/desmos/profiles/v1beta1/models_params.proto

Co-authored-by: Riccardo Montagnin <[email protected]>

…le-params-improvement � Conflicts: � CHANGELOG.md � proto/desmos/profiles/v1beta1/models_params.proto � x/profiles/keeper/genesis_test.go � x/profiles/keeper/keeper_params_test.go � x/profiles/legacy/v0160/store.go � x/profiles/types/genesis_test.go � x/profiles/types/models_params.go � x/profiles/types/models_params.pb.go � x/profiles/types/models_params_test.go

Signed-off-by: Riccardo Montagnin <[email protected]>

…into paul/oracle-params-improvement

See PR #547 (cherry picked from commit a549ef7) Signed-off-by: Riccardo Montagnin <[email protected]>

dadamu added 3 commits July 8, 2021 18:09

Init oracle params

6b39b80

Replace hard codedoracle params in relay

3baca61

Fix tests

cb2a628

dadamu added 6 commits July 8, 2021 19:52

Add validate function for oracle params

1d7695f

Add sim test

5984f5e

Improve oracle params validate and sim test functions

a17c949

Import oracle constants.go

69bf97e

Fix typo

fbd66bc

Fix oracle params validate

790d0a3

dadamu marked this pull request as ready for review July 9, 2021 06:43

Update CHANGELOG

61f74ea

dadamu requested review from RiccardoM and leobragaz July 9, 2021 06:47

dadamu added 2 commits July 9, 2021 17:05

Fix sim tests error

912dd30

Merge branch 'master' of github.com:desmos-labs/desmos into paul/orac…

c6de468

…le-params-improvement

RiccardoM reviewed Jul 9, 2021

View reviewed changes

x/profiles/types/models_params.go Outdated Show resolved Hide resolved

x/oracle/types/constants.go Outdated Show resolved Hide resolved

dadamu added 2 commits July 12, 2021 10:21

Merge branch 'master' of github.com:desmos-labs/desmos into paul/orac…

d7a98bd

…le-params-improvement

Remove maxmum checking

2d03e77

RiccardoM reviewed Jul 12, 2021

View reviewed changes

x/profiles/types/models_params.go Outdated Show resolved Hide resolved

dadamu added 3 commits July 12, 2021 14:41

Remove default oracle params value

32a3dcf

Remove unused tests

f6d05da

Revert tests

b55c97b

dadamu requested a review from RiccardoM July 12, 2021 07:00

RiccardoM reviewed Jul 12, 2021

View reviewed changes

Fix typo

c6f5491

RiccardoM reviewed Jul 12, 2021

View reviewed changes

Update x/profiles/types/models_params.go

46a1665

Co-authored-by: Riccardo Montagnin <[email protected]>

dadamu and others added 12 commits July 12, 2021 16:05

Update x/profiles/types/models_params.go

470e794

Co-authored-by: Riccardo Montagnin <[email protected]>

Update x/profiles/simulation/utils.go

b188c72

Co-authored-by: Riccardo Montagnin <[email protected]>

Update x/profiles/types/models_params.go

a80a286

Co-authored-by: Riccardo Montagnin <[email protected]>

Update proto/desmos/profiles/v1beta1/models_params.proto

cffebfd

Co-authored-by: Riccardo Montagnin <[email protected]>

Update proto/desmos/profiles/v1beta1/models_params.proto

91acf7c

Co-authored-by: Riccardo Montagnin <[email protected]>

Update proto/desmos/profiles/v1beta1/models_params.proto

f326669

Co-authored-by: Riccardo Montagnin <[email protected]>

Update proto/desmos/profiles/v1beta1/models_params.proto

56c5cb5

Co-authored-by: Riccardo Montagnin <[email protected]>

Update proto/desmos/profiles/v1beta1/models_params.proto

9b9b837

Co-authored-by: Riccardo Montagnin <[email protected]>

Update proto/desmos/profiles/v1beta1/models_params.proto

c261288

Co-authored-by: Riccardo Montagnin <[email protected]>

Update proto/desmos/profiles/v1beta1/models_params.proto

2c37eae

Co-authored-by: Riccardo Montagnin <[email protected]>

Update proto/desmos/profiles/v1beta1/models_params.proto

1409962

Co-authored-by: Riccardo Montagnin <[email protected]>

Regenerate proto

9793894

RiccardoM approved these changes Jul 12, 2021

View reviewed changes

RiccardoM and others added 5 commits July 12, 2021 10:20

Fixed merge conflicts

9cbd87c

Signed-off-by: Riccardo Montagnin <[email protected]>

Fix error

24e03ee

Fixed build errors

322419c

Signed-off-by: Riccardo Montagnin <[email protected]>

Merge remote-tracking branch 'origin/paul/oracle-params-improvement' …

8e6a99c

…into paul/oracle-params-improvement

RiccardoM merged commit a549ef7 into master Jul 12, 2021

RiccardoM deleted the paul/oracle-params-improvement branch July 12, 2021 09:13

RiccardoM pushed a commit that referenced this pull request Jul 12, 2021

Added oracle-related data to x/profiles params

1a91657

See PR #547 (cherry picked from commit a549ef7) Signed-off-by: Riccardo Montagnin <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Oracle params improvement #547

Oracle params improvement #547

dadamu commented Jul 8, 2021 •

edited

Loading

codecov bot commented Jul 8, 2021 •

edited

Loading

RiccardoM left a comment

RiccardoM left a comment

dadamu commented Jul 12, 2021

Oracle params improvement #547

Oracle params improvement #547

Conversation

dadamu commented Jul 8, 2021 • edited Loading

Description

Checklist

codecov bot commented Jul 8, 2021 • edited Loading

Codecov Report

RiccardoM left a comment

Choose a reason for hiding this comment

RiccardoM left a comment

Choose a reason for hiding this comment

dadamu commented Jul 12, 2021

dadamu commented Jul 8, 2021 •

edited

Loading

codecov bot commented Jul 8, 2021 •

edited

Loading