Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile CLI delete cmd fix #167

Merged
merged 1 commit into from
May 18, 2020
Merged

Conversation

leobragaz
Copy link
Contributor

Description

This PR fixes the bug inside the profile delete cli cmd.
Closes #166.

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@leobragaz leobragaz added kind/bug Something isn't working Status:R4R x/profiles Module that allows to create and manage decentralized social profiles labels May 15, 2020
@leobragaz leobragaz self-assigned this May 15, 2020
Copy link
Contributor Author

@leobragaz leobragaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re reviewed

@leobragaz leobragaz requested a review from RiccardoM May 15, 2020 10:29
@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #167 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   83.10%   83.10%           
=======================================
  Files          58       58           
  Lines        2444     2444           
=======================================
  Hits         2031     2031           
  Misses        356      356           
  Partials       57       57           

@leobragaz leobragaz added this to the v0.6.0 milestone May 15, 2020
@RiccardoM RiccardoM merged commit 5ff241a into master May 18, 2020
@RiccardoM RiccardoM deleted the leonardo/fix-profile-cli-cmd branch May 18, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working x/profiles Module that allows to create and manage decentralized social profiles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong accepted argument inside CLI profile delete
2 participants