Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicated message type events #1284

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Dec 28, 2023

Description

Currently, the sdk.MessageEventType is emitted twice in Desmos, it is because that cosmos-sdk already handles the default message type event.
As we can see, the example transaction has two message type event:

[
    {
        "events": [
            {
                "type": "message",
                "attributes": [
                    {
                        "key": "action",
                        "value": "/desmos.posts.v3.MsgCreatePost"
                    },
                    {
                        "key": "sender",
                        "value": "desmos1q35n50xnlj7lapfkzzcq5rvypcvhure0rr945u"
                    }
                ]
            },
            {
                "type": "message",
                "attributes": [
                    {
                        "key": "module",
                        "value": "posts"
                    },
                    {
                        "key": "action",
                        "value": "/desmos.posts.v3.MsgCreatePost"
                    },
                    {
                        "key": "sender",
                        "value": "desmos1q35n50xnlj7lapfkzzcq5rvypcvhure0rr945u"
                    }
                ]
            },
         ...skip
]

To fix it, we can safely remove the sdk.MessageEventType event inside Desmos modules.
References:
https://docs.cosmos.network/v0.47/learn/advanced/events#default-events
https://github.com/cosmos/cosmos-sdk/blob/v0.47.5/baseapp/baseapp.go#L848


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dadamu dadamu requested a review from a team as a code owner December 28, 2023 10:07
@github-actions github-actions bot added x/profiles Module that allows to create and manage decentralized social profiles x/subspaces Issue on the x/subspaces module x/relationships labels Dec 28, 2023
@dadamu dadamu changed the title chore: remove duplicated message events fix: remove duplicated message type events Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfefad2) 81.46% compared to head (22ed971) 81.04%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1284      +/-   ##
==========================================
- Coverage   81.46%   81.04%   -0.43%     
==========================================
  Files         218      218              
  Lines       18287    17880     -407     
==========================================
- Hits        14897    14490     -407     
  Misses       2778     2778              
  Partials      612      612              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dadamu dadamu force-pushed the paul/remove-duplicated-events branch from d14f79c to bee7a23 Compare December 28, 2023 10:20
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Paul! 🙏

@RiccardoM RiccardoM merged commit 4081830 into master Jan 8, 2024
34 checks passed
@RiccardoM RiccardoM deleted the paul/remove-duplicated-events branch January 8, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x/profiles Module that allows to create and manage decentralized social profiles x/relationships x/subspaces Issue on the x/subspaces module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants