Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated amino codec and GetSignBytes methods #1251

Closed
wants to merge 84 commits into from

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Sep 28, 2023

Description

Deps: #1246
This PR removes deprecated Amino codec and GetSignBytes.
https://docs.cosmos.network/v0.50/build/migrations/upgrading#modules


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dadamu dadamu requested a review from a team as a code owner September 28, 2023 14:48
@github-actions github-actions bot added x/profiles Module that allows to create and manage decentralized social profiles kind/ci Improve the CI/CD x/subspaces Issue on the x/subspaces module x/CLI kind/build Related to the build of the project x/relationships labels Sep 28, 2023
@dadamu dadamu force-pushed the paul/remove-deprecated-amino-codec branch from c37da5d to 763c8fd Compare September 28, 2023 14:59
@dadamu dadamu marked this pull request as draft September 28, 2023 15:03
@dadamu dadamu closed this Sep 28, 2023
@dadamu dadamu deleted the paul/remove-deprecated-amino-codec branch September 28, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/build Related to the build of the project kind/ci Improve the CI/CD x/CLI x/profiles Module that allows to create and manage decentralized social profiles x/relationships x/subspaces Issue on the x/subspaces module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant