Skip to content

Commit

Permalink
fix: add missing unpack interfaces function for `LinkChainAccountPack…
Browse files Browse the repository at this point in the history
…etData` (#1277)

## Description

Closes: #XXXX

<!-- Add a description of the changes that this PR introduces and the
files that
are the most critical to review. -->

This PR fixed `LinkChainAccountPacketData` unmarshalling JSON issue that
leads to fail to get the cached value for its `Any` fields.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is
not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type
prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json)
in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR
Targeting](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building
modules](https://docs.cosmos.network/v0.44/building-modules/intro.html)
- [ ] included the necessary unit and integration
[tests](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go
code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable
and please add
your handle next to the items reviewed if you only reviewed selected
items.*

I have...

- [ ] confirmed the correct [type
prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json)
in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
  • Loading branch information
dadamu authored Dec 11, 2023
1 parent a7bf88f commit 99fe161
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions x/profiles/types/models_packets.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,3 +65,20 @@ func (p LinkChainAccountPacketData) Validate() error {
func (p LinkChainAccountPacketData) GetBytes(cdc codec.Codec) ([]byte, error) {
return sdk.SortJSON(cdc.MustMarshalJSON(&p))
}

// UnpackInterfaces implements codectypes.UnpackInterfacesMessage
func (p *LinkChainAccountPacketData) UnpackInterfaces(unpacker codectypes.AnyUnpacker) error {
var address AddressData
if err := unpacker.UnpackAny(p.SourceAddress, &address); err != nil {
return err
}

if err := p.SourceProof.UnpackInterfaces(unpacker); err != nil {
return err
}

if err := p.DestinationProof.UnpackInterfaces(unpacker); err != nil {
return err
}
return nil
}

0 comments on commit 99fe161

Please sign in to comment.