Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEQ-2705] george / FEQ-2705 / Avoid Triggering Coveralls Workflow on PR Edits #17891

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

heorhi-deriv
Copy link
Contributor

Changes:

The Coveralls workflow was being unnecessarily triggered on PR metadata edits (e.g., title or description changes) in the deriv-app project. This was caused by the inclusion of the edited event type in the workflow trigger for pull_request.

This PR removes the edited event type to ensure the workflow only runs for relevant events like new commits or PR creation, optimizing CI/CD resource usage.

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 24, 2024 7:44am

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12478503118

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on FEQ-2705-Avoid-Triggering-Coveralls-Workflow-on-PR-Edits at 53.901%

Totals Coverage Status
Change from base Build 12478041593: 53.9%
Covered Lines: 33038
Relevant Lines: 57117

💛 - Coveralls

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17891](https://github.com/deriv-com/deriv-app/pull/17891)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-heorhi-deriv-feq-2705-avoid-triggerin-882dd2.binary.sx?qa_server=red.derivws.com&app_id=23848
    - **Original**: https://deriv-app-git-fork-heorhi-deriv-feq-2705-avoid-triggerin-882dd2.binary.sx
- **App ID**: `23848`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 33
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-feq-2705-avoid-triggerin-882dd2.binary.sx/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants