Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRAH-5056] Suisin/chore: change app ID based on FF value #17889

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

suisin-deriv
Copy link
Contributor

Changes:

App ID should change to 61554 when trigger_login_for_hub_country_list feature flag value is true for certain countries

Screenshots:

Screen.Recording.2024-12-24.at.2.59.33.PM.mov

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 24, 2024 7:48am

@coveralls
Copy link

coveralls commented Dec 24, 2024

Pull Request Test Coverage Report for Build 12478403664

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on suisin/TRAH5056/change_app_id_based_on_FF at 53.896%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/App/app.jsx 0 5 0.0%
Totals Coverage Status
Change from base Build 12478041593: 53.9%
Covered Lines: 33038
Relevant Lines: 57122

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Dec 24, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17889](https://github.com/deriv-com/deriv-app/pull/17889)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-suisin-deriv-suisin-trah5056changeapp-05c295.binary.sx?qa_server=red.derivws.com&app_id=31531
    - **Original**: https://deriv-app-git-fork-suisin-deriv-suisin-trah5056changeapp-05c295.binary.sx
- **App ID**: `31531`

Copy link
Contributor

github-actions bot commented Dec 24, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 35
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-trah5056changeapp-05c295.binary.sx/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants