-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRAH-5056] Suisin/chore: change app ID based on FF value #17889
Open
suisin-deriv
wants to merge
2
commits into
deriv-com:master
Choose a base branch
from
suisin-deriv:suisin/TRAH5056/change_app_id_based_on_FF
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[TRAH-5056] Suisin/chore: change app ID based on FF value #17889
suisin-deriv
wants to merge
2
commits into
deriv-com:master
from
suisin-deriv:suisin/TRAH5056/change_app_id_based_on_FF
+25
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suisin-deriv
requested review from
amina-deriv,
balakrishna-deriv,
farrah-deriv,
habib-deriv,
matin-deriv,
nijil-deriv,
sandeep-deriv and
yashim-deriv
as code owners
December 24, 2024 07:00
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 12478403664Details
💛 - Coveralls |
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-trah5056changeapp-05c295.binary.sx/ |
shontzu-deriv
approved these changes
Dec 24, 2024
aizad-deriv
approved these changes
Dec 24, 2024
habib-deriv
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
App ID should change to 61554 when
trigger_login_for_hub_country_list
feature flag value is true for certain countriesScreenshots:
Screen.Recording.2024-12-24.at.2.59.33.PM.mov