Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRAH-4715/show_account_settings_header_when_redirected_from_low_Code_to_account_settings_high_sode #17878

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

amina-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 23, 2024 11:30am

@coveralls
Copy link

coveralls commented Dec 23, 2024

Pull Request Test Coverage Report for Build 12465804724

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 99 (5.05%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 53.811%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/Stores/common-store.js 0 1 0.0%
packages/components/src/components/page-overlay/page-overlay.tsx 0 2 0.0%
packages/core/src/App/Containers/Layout/header/header.tsx 2 6 33.33%
packages/core/src/App/Components/Layout/Header/toggle-menu-drawer-accounts-os.jsx 2 89 2.25%
Files with Coverage Reduction New Missed Lines %
packages/bot-web-ui/src/app/app-main.tsx 1 84.21%
Totals Coverage Status
Change from base Build 12431059658: -0.09%
Covered Lines: 33042
Relevant Lines: 57209

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Dec 23, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17878](https://github.com/deriv-com/deriv-app/pull/17878)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-amina-deriv-amina-trah4715redirection-409e69.binary.sx?qa_server=red.derivws.com&app_id=24183
    - **Original**: https://deriv-app-git-fork-amina-deriv-amina-trah4715redirection-409e69.binary.sx
- **App ID**: `24183`

Copy link
Contributor

github-actions bot commented Dec 23, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 33
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-amina-deriv-amina-trah4715redirection-409e69.binary.sx/

Copy link
Contributor

@habib-deriv habib-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants