-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GRWT-3938 / Kate / Insufficient balance error when changing language #17874
Open
kate-deriv
wants to merge
1
commit into
deriv-com:master
Choose a base branch
from
kate-deriv:kate/GRWT-3938/error_on_language_change
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
GRWT-3938 / Kate / Insufficient balance error when changing language #17874
kate-deriv
wants to merge
1
commit into
deriv-com:master
from
kate-deriv:kate/GRWT-3938/error_on_language_change
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 12432162591Details
💛 - Coveralls |
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-grwt-3938erroronlangu-c6b605.binary.sx/ |
⏳ Generating Lighthouse report... |
nijil-deriv
approved these changes
Dec 20, 2024
henry-deriv
approved these changes
Dec 23, 2024
akmal-deriv
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Reason of the bug:
after switching the language we are opening a new websocket connection in both cases (desktop + mobile). In desktop, in buy 'request' we are sending a new contract id from the second opened websocket connection, BUT in mobile we are STILL USING THE OLD ID.
Solution:
updating the store on language change. Additionally removed code of invalid proposal from conditions of showing the error modal.
Screenshots:
Screen.Recording.2024-12-20.at.4.18.15.PM.mov