Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRWT-3938 / Kate / Insufficient balance error when changing language #17874

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kate-deriv
Copy link
Contributor

@kate-deriv kate-deriv commented Dec 20, 2024

Changes:

Reason of the bug:
after switching the language we are opening a new websocket connection in both cases (desktop + mobile). In desktop, in buy 'request' we are sending a new contract id from the second opened websocket connection, BUT in mobile we are STILL USING THE OLD ID.

Solution:
updating the store on language change. Additionally removed code of invalid proposal from conditions of showing the error modal.

Screenshots:

Screen.Recording.2024-12-20.at.4.18.15.PM.mov

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 20, 2024 1:19pm

@coveralls
Copy link

coveralls commented Dec 20, 2024

Pull Request Test Coverage Report for Build 12432162591

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 53.901%

Totals Coverage Status
Change from base Build 12431059658: -0.003%
Covered Lines: 33035
Relevant Lines: 57112

💛 - Coveralls

@kate-deriv kate-deriv marked this pull request as ready for review December 20, 2024 13:19
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17874](https://github.com/deriv-com/deriv-app/pull/17874)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-kate-deriv-kate-grwt-3938erroronlangu-c6b605.binary.sx?qa_server=red.derivws.com&app_id=32868
    - **Original**: https://deriv-app-git-fork-kate-deriv-kate-grwt-3938erroronlangu-c6b605.binary.sx
- **App ID**: `32868`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 38
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-grwt-3938erroronlangu-c6b605.binary.sx/

Copy link
Contributor

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants