-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTRA-2471 / Kate / DND console error #17859
Open
kate-deriv
wants to merge
2
commits into
deriv-com:master
Choose a base branch
from
kate-deriv:kate/DTRA-2471/dnd_library_replacement
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
DTRA-2471 / Kate / DND console error #17859
kate-deriv
wants to merge
2
commits into
deriv-com:master
from
kate-deriv:kate/DTRA-2471/dnd_library_replacement
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 12408672835Details
💛 - Coveralls |
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-dtra-2471dndlibraryre-e70b2a.binary.sx/ |
vinu-deriv
approved these changes
Dec 19, 2024
⏳ Generating Lighthouse report... |
nijil-deriv
approved these changes
Dec 19, 2024
henry-deriv
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Reasons:
TrackJS
{"message":"Invariant failed"}
was caused byreact-beautiful-dnd
library, that is used for trade types drag-and-drop functionality. In all logs users were changing the order of trade types and get an error. In dev mode on localhost it's possible to reproduce it and get 'Droppable: unsupported nested scroll container detected.A Droppable can only have one scroll parent (which can be itself)Nested scroll containers are currently not supported.'
.Solutions:
There are 3 ways of solving the issue:
overflow
css property equal toscroll/auto
and make them not scrollable. According to the library documentation it's possible to have only 1 scrollable parent, so in my implementation it'saction-sheet--content trade-types-dialog__content
, because we want to leave trade types scrollable on small screens.react-beautiful-dnd
library will be deprecated in 2025 (link1 and link2), so sooner or earlier we need to migrate to another library.window['__react-beautiful-dnd-disable-dev-warnings'] = true;
. Not recommendedScreenshots:
Screenshot of the error on localhost