Thisyahlen/fix: account switching #17831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisyahlen-deriv
requested review from
amina-deriv,
balakrishna-deriv,
farrah-deriv,
habib-deriv,
matin-deriv,
nijil-deriv,
sandeep-deriv and
yashim-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thisyahlen-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
thisyahlen-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-fix-accou-6a88b5.binary.sx/ |
Pull Request Test Coverage Report for Build 12364535986Details
💛 - Coveralls |
sandeep-deriv
approved these changes
Dec 17, 2024
rupato-deriv
pushed a commit
that referenced
this pull request
Dec 17, 2024
* fix: account switching * chore: empty commit --------- Co-authored-by: Thisyahlen <[email protected]>
shahzaib-deriv
added a commit
that referenced
this pull request
Dec 19, 2024
* translations: 📚 sync translations with crowdin (#17648) Co-authored-by: DerivFE <[email protected]> * chore: remove signup_continued action (#17595) * fix: trading platform status unit test (#17650) * chore: mt5 reset password unit test (#17628) * DTRA-1933 / Kate / Console error fix (#17508) * chore: remove translation from label * chore: remove comment * chore: add brackets * chore: add key for icon * feat: enable spanish for wallets (#17570) * Aswathy/CRO-778/feat: Added the console error tracking for the virtual signup flow (#17497) * feat: added the console error tracking for the virtual signup flow * fix: removed the console errors * feat: added the console trackjs error for the user signup flow * fix: peer comments * fix: removed the localized error message * fix: removed the localize form analytics * fix: changed the naming of the feature f;ag variable * fix: added a condition inside the country selection screen for capturing multiple errors * fix: updated the ref with state of password model * fix: added the console * fix: added the feature condition inside trackconsole method * fix: changed the default value to true * fix: added the dependency for useeffect * fix: peer comments * fix: added the screen name for the signup button * Agrim/CRO-770/Missing-Userid (#17549) * fix: testing user id * chore: add cacheTrackEvents for missing user id * fix: fix type * fix: revert isReady change * fix: failing test cases * fix: empty commit * fix: test * fix: change password success modal (#17608) * fix: add price info (#17641) * GRWT-2395 / Kate / [Dtrader -V2] Risk management changes (#17567) * refactor: reset the stop loss value on trade type change * feat: create error observer component for trade params error and a helper hook * refactor: tak * refactor: add tests for new component * refactor: hook * fix: independent tp and sl validation * refactor: add tests * chore: remove unused code * fix: add date start field to the observes * refactor: rename componnets and params * chore: trustpilot changes (#17581) * [UPM1755] Suisin/chore: update utils package to fix state regex issue (#17655) * chore: update utils package to fix state regex issue * chore: empty commit * refactor: update lowcode to highcode redirect handling (#17631) * fix(wallets): 🚑 account creation (#17623) * Revert "Agrim/CRO-770/Missing-Userid (#17549)" (#17657) This reverts commit baf4303. * fix: Run panel animation result does not match contact result on win/loss (#17627) * translations: 📚 sync translations with crowdin (#17661) Co-authored-by: DerivFE <[email protected]> * [WALL] george / WALL-5135 / Remove the jurisdiction information on compare account table for wallets (#17516) * fix(wallets): 🚑 remove the jurisdiction information * refactor(wallets): 🔥 remove unused hardcoded values * refactor(wallets): ♻️ refactor compare accounts table to use data from the API * chore: exclude gold MT5 product from compare table * fix: console error (#17668) * translations: 📚 sync translations with crowdin (#17671) Co-authored-by: DerivFE <[email protected]> * [UPM-1668] Suisin/pnv/implement phone number code dropdown (#17311) * chore: change from normal input field to dropdown with input field for confirm phone number screen * chore: update phone number dropdown list and added a hook * chore: add code dropdown in legacy settings page * chore: hide sms based on carriers available * chore: update functionality for phone number in personal details * chore: fix test case and changes validation based on FF * chore: make inputmode numeric * chore: change display mobile number in phone otp verification page and verified modal * chore: add validation for calling_country_code and fix logics for FF off * chore: upgrade quill-ui package for Input Phone Number component * chore: upgrade package to add more flags in country code drop down * chore: fix changing language logs user out issue * chore: add loading checks for confirm phone number screen * chore: fix verified hint message * chore: fix mobile modal for input phone number dropdown * chore: hide verify and notification if carriers are empty * chore: call phone_settings on first initialization * chore: add condition for displaying sms and whatsapp button * chore: update logic lo check global carriers * chore: change select native to include boolean value * chore: add check to hide or display verify button * chore: fix test case fail for validation * chore: update code based on comments * chore: fix unable to submit profile settings * chore: update quill-ui package and include search function * chore: fix console log error and submitting phone number error * chore: update code based on comments * chore: update quill-ui package to fix bundle size issue * chore: remove unused commented code * chore: switch off autoComplete for browsers * chore: add + sign at step 3 and verified modal * chore: sort list based on alphabetical order * chore: fix undefined error message and test case failing issue * chore: update quill-ui package to have scroll to value selected * chore: edit scss for rtl and update package for fix search bar * chore: update package-lock.json * chore: make rtl look better in phone and desktop * chore: fix verify button disable and enable issue * chore: fix GB console log issue * chore: edit error message for country code * chore: make country code dropdown to 40% width * translations: 📚 sync translations with crowdin (#17677) Co-authored-by: DerivFE <[email protected]> * [BOT]/GRWT-2389/Announcement click & action events should be set to English (#17637) * fix: rudderstack action in english * fix: change var name * fix: action language fix * [WALL] george / WALL-5075 / EU migration banner for existing clients (#17583) * feat(appstore): ✨ add wallet migration flow for EU clients * fix(appstore): 🚑 fix demo eu migration flow * fix(wallets): 🚑 fix modal height in mobile view * translations: 📚 sync translations with crowdin (#17681) Co-authored-by: DerivFE <[email protected]> * GRWT-2668 / Kate / [DTrader-V2] Payout per point display value is not refreshing when changing market type (#17644) * fix: payout per point component * fix: add barrier to the array with dependencies * fix: remove incorrect delay (#17651) * chore: fix notification and sms to be same as prod (#17682) * translations: 📚 sync translations with crowdin (#17689) Co-authored-by: DerivFE <[email protected]> * translations: 📚 sync translations with crowdin (#17690) Co-authored-by: DerivFE <[email protected]> * translations: 📚 sync translations with crowdin (#17692) Co-authored-by: DerivFE <[email protected]> * Amina/[TRAH-4455]/remove header on account settings redirection (#17649) * fix: redirection * fix: redirection * fix: redirection * fix: remove unrelated file * fix: type * fix: type * translations: 📚 sync translations with crowdin (#17694) Co-authored-by: DerivFE <[email protected]> * [WALL] Jim/WALL-4855/add poi poa badges for mf account (#17555) * feat: add poi poa badges for mf account * ci: fix failing tests * refactor: use clientverificationbadge instead of walletstatusbadge * chore: undo walletstatus related changes * chore: hide badge for demo * chore: replace is_virtual from activewallet with activelinkedtoaccount * ci: fix failing test cases * chore: extract conditional to a variable * chore: replace displaymoney with walletmoney component and show balance for demo accounts * ci: fix failing test case * revert: undo auto-format * fix: demo create success modal content (#17557) * translations: 📚 sync translations with crowdin (#17697) Co-authored-by: DerivFE <[email protected]> * chore: add caching (#17663) * Revert "chore: add caching (#17663)" (#17700) This reverts commit 5aa10ad. * [BOT-2440]/mayuran/tutorial-video bug (#17669) * fix: tutorial fix * fix: bug * [FEQ] george / FEQ-2702 / Improve Coverall workflow time execution. Part 2. Adding caching npm packages (#17702) * chore: add caching * fix: 🚑 cache not reading form base repo * Revert "[FEQ] george / FEQ-2702 / Improve Coverall workflow time execution. P…" (#17706) This reverts commit 89a90c7. * translations: 📚 sync translations with crowdin (#17707) Co-authored-by: DerivFE <[email protected]> * [FEQ] george / FEQ-2702 / Improve Coverall workflow time execution. Part 2. Adding caching npm packages (#17708) * chore: add caching * fix: 🚑 cache not reading form base repo * fix: 🚑 add update cache workflow, fix coverall restore cache * Rename update_cache.yml to update_npm_cache.yml * fix: add push trigger to master for coverall workflow (#17713) * [TRAH4525] Suisin/chore: fix cfd not showing to spain users (#17709) * chore: fix cfd not showing to spain users * fix: loader blinking issue * chore: revert types changes for stores * perf: remove redundant cache key restoration (#17718) * chore: remove utm_data and gclid from cookie upon logout (#17720) * Nuzhy/CSIT-1700/intercom integration (#17672) * chore: added POC for intercom * chore: keep user anonymous for now * chore: added livechat condition for intercom * chore: added user signature * fix: clear chat on loggout handled * fix: nitpick * fix: fetch flag in hook, removed from live-chat * fix: re-initialize intercom on logout --------- Co-authored-by: Prince <[email protected]> * [WALL] Jim/WALL-5129/redirection to os real account sign up flow from mf traders hub on add new wallet section (#17640) * feat: redirect to tradershub out systems * chore: pass currency to query params * test: fix failing tests and add more tests * test: remove unnecessary attributes from mock objects * test: remove unnecessary attributes from mock objects * test: remove unnecessary attributes from mock objects * chore: update feature flag key * [CRO-880]/Agrim_Amina/fix binary userid (#17673) * fix: testing user id * chore: add cacheTrackEvents for missing user id * fix: fix type * fix: revert isReady change * fix: failing test cases * fix: empty commit * fix: test * fix: userid * fix: Trigger Build --------- Co-authored-by: Agrim Jain <[email protected]> * Akmal / feat: replace dtrader videos (#17564) * feat: replace dtrader videos * feat: remove extra variable * fix: stake value fix on crypto currency change (#17683) * DTRA-2131 / Kate / Virtual keyboard hook (#17559) * refactor: add hook for detecting keyboard * chore: replace logs * chore: add one more check * refactor: add scrolling for rm * refactor: add tests * refactor: apply suggestions * translations: 📚 sync translations with crowdin (#17729) Co-authored-by: DerivFE <[email protected]> * translations: 📚 sync translations with crowdin (#17731) Co-authored-by: DerivFE <[email protected]> * [P2PS] / Ameerul / P2PS-4532 PA client gets logout when login (#17699) * fix: added is_authroize check from client store before calling p2p_settings * fix: set mt5_login_list in WS.authorized * translations: 📚 sync translations with crowdin (#17736) Co-authored-by: DerivFE <[email protected]> * fix(wallets): 🚑 remaining amount error (#17680) * DON't MERGE - [WALL] george / WALL-5147 / Gold MT5 account creation flow on Wallets (#17607) * feat(wallets): ✨ add Gold MT5 account creation real and demo * chore: replace company name from API for tnc, add dml shortcode support * chore: add gold mt5 acc into compare acc table * feat(wallets): ✨ add mt5 gold into compare accounts table real + demo * feat(wallets): ✨ add mf mt5 gold support * feat(wallets): ✨ implement compare accounts table for MFW clients * fix(wallets): 🔥 remove Boom 300 from compare acc table * [WALL] Jim/WALL-5218/send all accounts with their tokens to os (#17738) * chore: send all accounts with their tokens * chore: change os_auth_token to os_auth_tokens * ci: fix failing tests * ci: fix failing tests * [TRAH]/Hasan/TRAH-4439/Gold MT5 account creation flow (#17565) * feat: added gold account details to the mt5 account list * feat: added gold icon * feat: added new tag to gold card * feat: added gold success icon * feat: added multi action to gold * feat: added gold icon in trade modal * feat: added gold to transfer page * feat: added gold title to trade modal * feat: optimized svg accounts * fix: bring back cfd_account_display function call * feat: added mauritius tnc * feat: added gold title to success message * feat: added gold demo title to enter password title * feat: added gold compare accounts * feat: added gold demo compare accounts * fix: build issue * fix: build issue * fix: removed console * fix: fixed financial demo title * fix: fixed financial title * fix: changed description * feat: added mt5 gold icon in close account modal * fix: added shortcode in cfd constant * fix: added shortcode in cfd constant * fix: fixed investor password for gold account * feat: fixed short code generation * fix: made dml capital * fix: made dml capital * fix: removed gold from compare account * fix: reset password for MF account * fix: eu trade modal icon * translations: 📚 sync translations with crowdin (#17755) Co-authored-by: DerivFE <[email protected]> * [TRAH4562] Suisin/chore: add condition to check is_eu_user on giving contentFlag (#17742) * chore: add condition to check is_eu_user on giving contentFlag * chore: fix mt5 icon not displaying when logged out * [WALL5207] Suisin/chore: update content for tnc modal (#17733) * chore: update content for tnc modal * chore: add livechat link * [BOT]/mayuran/bot-2180/ improve journal messages (#17666) * fix: improve journal messages * fix: change unwanted code * fix: unwanted code * fix: improve journal messages * fix: move helper function * fix: error message * fix: added translation * fix: Search by "all" results are not shown correctly (#17725) * [DTRA-V2] henry/grwt-1761/dtraderV2-desktop-feature-flag (#17573) * fix: initial commit * feat: separate commit * chore: fix tests * fix: change feature flag name * fix: change feature flag name * fix: resolve comments * chore: remove commented code * chore: refactor * fix: ui for tooltip of onborading guide (#17726) * translations: 📚 sync translations with crowdin (#17767) Co-authored-by: DerivFE <[email protected]> * fix: fix the change of variable name is_dtrader_v2 in trade store (#17769) * feat: update deriv-charts version (#17774) * feat: update deriv-charts version * fix: add deriv chart dependency * fix: updated platform config to href from link_to (#17773) * fix: draggable component console css errors (#17781) * fix: draggable component console css errors * chore: add try catch * [BOT]maryia/BOT-2462/fix: Total Payout remains zero for multipliers and accumulator QS (#17703) * fix: Total Payout remains zero for multipliers and accumulator QS * refactor: fix the issue with simplier approach * chore: trigger vercel * chore: redirect to auth straight after wallet migration (#17361) * chore: redirect to auth straight after wallet migration * chore: add oauthlogout to upgrade logout wallet modal * chore: pass oauthlogout from core --------- Co-authored-by: Thisyahlen <[email protected]> * [WALL] Lubega / WALL-4830 / Enable all languages in wallets (#17662) * feat: enable all languages in wallets * fix: language settings unit test * fix: password modal tnc redirection language * Update types.ts * fix: remove wallets unsupported languages * fix: language settings unit test * fix: removed test case * [WALL] Lubega / WALL-5219 / CtraderSuccessModal unit test (#17748) * chore: ctrader success modal unit test * fix: clean up * [WALL] Lubega / WALL-5063/ No currency responsive display (#17675) * fix: no currency responsive * fix: revert icons.js * fix: clean up * translations: 📚 sync translations with crowdin (#17789) Co-authored-by: DerivFE <[email protected]> * translations: 📚 sync translations with crowdin (#17790) Co-authored-by: DerivFE <[email protected]> * [WALL] Lubega / WALL-5222 / MT5 trade modal dynamic white label links (#17756) * fix: mt5 trade modal white label links * fix: modal trade wrapper links * fix: webtrader url format * fix: webtrader url format * fix: download button no link display * fix: download button no link display * Akmal / fix: mismatch duration values (#17698) * fix: mismatch duration values * fix: duration end date logic * fix: split component-scoped and global end_time states * feat: refactor state logic inside duration component * feat: delete outdated test case * chore: fixing the 5 min difference * chore: package --------- Co-authored-by: ahmadtaimoor-deriv <[email protected]> * BOT-2443/mayuran/fix: ui bugs (#17743) * fix: ui bugs * chore: trigger vercel * DTRA-1886 / Kate / Trade type updates (#17501) * feat: add carousel for trade type selection modal * refactor: add conditions for showing divider * refactor: add tests and remove todos * chore: extract common props * chore: apply suggestions * fix: tests * [DTRA-V2]/Ahmad/Adding Loader when switching Demo to Real (#17350) * chore: loader added for is_switching * chore: test added * chore: fix * chore: fix * [WALL5212] Suisin/chore: create reacceptance tnc notification (#17753) * chore: create reacceptance tnc notification * chore: remove const values and update it to use account_settings values * chore: remove comma from date * translations: 📚 sync translations with crowdin (#17801) Co-authored-by: DerivFE <[email protected]> * fix(wallets): 🚑 fix ctrader webterminal link (#17778) * Hirad/TRAH-4545/redirection from os to legacy (#17780) * chore: updating redirections for OutSystems redirection * chore: adding poa and poi redirections * chore: removed smart_trader * chore: improving the code * chore: changing variable names * chore: added trade_type * chore: added redirection for trade_types * chore: adding some values to the redirection * chore: added os settings redirection * translations: 📚 sync translations with crowdin (#17807) Co-authored-by: DerivFE <[email protected]> * [WALL] Jim/WALL-5221/enable real demo switcher for users without real wallets (#17751) * chore: send all accounts with their tokens * chore: change os_auth_token to os_auth_tokens * ci: fix failing tests * ci: fix failing tests * chore: enable real tab or button on demo or real switcher * ci: fix failing tests * style: update test description to a more meaningful one * chore: only redirect when the active wallet is demo and switching to real * test: add more tests * Rupato/BOT-2436/fix: updated blockly method (#17772) * fix: updated blockly method * fix: currency on stop loss and take profit blocks * fix: added onchange check * feat(translations): add new wallet migration video translations for multiple languages (#17805) * henry/grwt-3242/chore: quill-icons package update (#17656) * chore: package update * fix: replace icons * fix: wrong import * fix: add color * fix: failing test * fix: failing test 2 * fix: change to css variable * chore: package-lock update * fix: build fail * fix: build fail * translations: 📚 sync translations with crowdin (#17817) Co-authored-by: DerivFE <[email protected]> * chore: oidc setup login/logout (#17746) * chore: install latest aiuth-client * chore: fix tests * chore: add oidc setup and silent login/logout * chore: fix test * chore: empty commit * chore: change text and localize it * chore: address comments and add wallet logout and login * chore: conflicts --------- Co-authored-by: Thisyahlen <[email protected]> * translations: 📚 sync translations with crowdin (#17821) Co-authored-by: DerivFE <[email protected]> * chore: adding network information to page view event (#17795) * DTRA-2226 / Kate / Barrier and markers updates (#17461) * refactor: colors changes for barrier and indicator * chore: revert change of shade height * fix: type * chore: improve classname * chore: apply suggestions * fix: loss icon fix --------- Co-authored-by: vinu-deriv <[email protected]> * feat: chart version update (#17818) * [WALL] george / WALL-5235 / Notification Missing on Trader’s Hub Page for Wallet Accounts (#17802) * feat: enhance RootComponent and App to include notification messages UI * fix: update notifications display logic in App component * Thisyahlen/fix: account switching (#17831) * fix: account switching * chore: empty commit --------- Co-authored-by: Thisyahlen <[email protected]> * [CFDS-4846] Suisin/chore: fix misleading info when creating DXTrader account (#17823) * chore: fix misleading info when creating DXTrader account * chore: update code based on comments * feat: add OSRedirect component and update routes config --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <[email protected]> Co-authored-by: Agrim Jain <[email protected]> Co-authored-by: lubega-deriv <[email protected]> Co-authored-by: kate-deriv <[email protected]> Co-authored-by: Aswathy-Deriv <[email protected]> Co-authored-by: utkarsha-deriv <[email protected]> Co-authored-by: Sui Sin <[email protected]> Co-authored-by: shontzu <[email protected]> Co-authored-by: George Usynin <[email protected]> Co-authored-by: amam-deriv <[email protected]> Co-authored-by: maryia-matskevich-deriv <[email protected]> Co-authored-by: mayuran-deriv <[email protected]> Co-authored-by: amina-deriv <[email protected]> Co-authored-by: Jim Daniels Wasswa <[email protected]> Co-authored-by: Shayan Khaleghparast <[email protected]> Co-authored-by: Nuzhy-Deriv <[email protected]> Co-authored-by: Prince <[email protected]> Co-authored-by: Agrim Jain <[email protected]> Co-authored-by: Akmal Djumakhodjaev <[email protected]> Co-authored-by: vinu-deriv <[email protected]> Co-authored-by: Ameerul Hady <[email protected]> Co-authored-by: Hasan Mobarak <[email protected]> Co-authored-by: henry-deriv <[email protected]> Co-authored-by: Farabi <[email protected]> Co-authored-by: Shafin Al Karim <[email protected]> Co-authored-by: thisyahlen <[email protected]> Co-authored-by: Thisyahlen <[email protected]> Co-authored-by: ahmadtaimoor-deriv <[email protected]> Co-authored-by: hirad-deriv <[email protected]> Co-authored-by: rupato-deriv <[email protected]> Co-authored-by: vinu-deriv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Removed tokens and account1 from localStorage once user is logged in.
config.tokens and config.account1 was set in localStorage in the callback page so that it doesnt affect legacy code. So once client store retrieves the tokens and account1 and set the
client.accounts, we dont need config.tokens and account1 anymore. Therefore removing it