-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jim/wall 5227/switch ws connection when clients switch between real and demo wallets #17820
Open
jim-deriv
wants to merge
9
commits into
deriv-com:master
Choose a base branch
from
jim-deriv:jim/wall-5227/switch-ws-connection-when-clients-switch-between-real-and-demo-wallets
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-5227/switch-ws-connection-when-clients-switch-between-real-and-demo-wallets
…-5227/switch-ws-connection-when-clients-switch-between-real-and-demo-wallets
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-jim-deriv-jim-wall-5227switch-ws-conn-b9f9f6.binary.sx/ |
Pull Request Test Coverage Report for Build 12346181102Details
💛 - Coveralls |
jim-deriv
requested review from
amina-deriv,
balakrishna-deriv,
farrah-deriv,
habib-deriv,
matin-deriv,
nijil-deriv,
sandeep-deriv,
yashim-deriv and
heorhi-deriv
as code owners
December 16, 2024 03:30
…-5227/switch-ws-connection-when-clients-switch-between-real-and-demo-wallets
heorhi-deriv
approved these changes
Dec 16, 2024
nijil-deriv
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Added logic to switch between
green
andblue
and vice versa, when a user switches from real to demo and vice versa.Screenshots:
Desktop
Switch.Server.Desktop.mov
Responsive
Switch.Server.Responsive.mov