Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jim/wall 5227/switch ws connection when clients switch between real and demo wallets #17820

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

jim-deriv
Copy link
Contributor

Changes:

Added logic to switch between green and blue and vice versa, when a user switches from real to demo and vice versa.

Screenshots:

Desktop

Switch.Server.Desktop.mov

Responsive

Switch.Server.Responsive.mov

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 16, 2024 5:18am

Copy link
Contributor

github-actions bot commented Dec 16, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17820](https://github.com/deriv-com/deriv-app/pull/17820)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-jim-deriv-jim-wall-5227switch-ws-conn-b9f9f6.binary.sx?qa_server=red.derivws.com&app_id=32869
    - **Original**: https://deriv-app-git-fork-jim-deriv-jim-wall-5227switch-ws-conn-b9f9f6.binary.sx
- **App ID**: `32869`

Copy link
Contributor

github-actions bot commented Dec 16, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 36
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-jim-deriv-jim-wall-5227switch-ws-conn-b9f9f6.binary.sx/

@coveralls
Copy link

coveralls commented Dec 16, 2024

Pull Request Test Coverage Report for Build 12346181102

Details

  • 11 of 20 (55.0%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 53.876%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/api-v2/src/ws-client/ws-client.ts 1 2 50.0%
packages/api-v2/src/APIProvider.tsx 7 9 77.78%
packages/shared/src/utils/config/config.ts 1 3 33.33%
packages/api-v2/src/AuthProvider.tsx 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
packages/shared/src/utils/config/config.ts 1 11.11%
Totals Coverage Status
Change from base Build 12345541133: -0.006%
Covered Lines: 33005
Relevant Lines: 57105

💛 - Coveralls

…-5227/switch-ws-connection-when-clients-switch-between-real-and-demo-wallets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants