Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] george / WALL-4518 / Update Fiat Onramp Implementation #16976

Conversation

heorhi-deriv
Copy link
Contributor

@heorhi-deriv heorhi-deriv commented Sep 25, 2024

Changes:

Legacy cashier

  • Remove FiatOnramp tab for unsupported currencies.
  • Remove FiatOnramp box for unsupported currencies on crypto deposit page.
  • Redirect to /cashier/deposit if /cashier/onramp is manually entered for unsupported currencies.
  • Exclude unsupported currencies from the Choose account and Add new account modals in the deposit-onramp section.
  • Include a disclaimer in the modals: Some currencies may not be supported by fiat onramp.

Wallets

  • Remove the FiatOnramp section for unsupported currencies.
  • Redirect to /wallet/deposit if /wallet/onramp is manually entered for unsupported currencies.
  • Align Back button in onramp
  • Align Transactions status in crypto Deposit tab

Screenshots:

Legacy cashier

Screen.Recording.2024-09-25.at.13.33.48.mov

Wallets

Screen.Recording.2024-09-25.at.14.34.39.mov

Screenshot 2024-09-26 at 09 14 34
Screenshot 2024-09-26 at 09 14 38

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 4, 2024 9:41am

Copy link
Contributor

github-actions bot commented Sep 25, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16976](https://github.com/binary-com/deriv-app/pull/16976)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-heorhi-deriv-wall-4518-update-fiat-on-c00251.binary.sx?qa_server=red.derivws.com&app_id=32691
    - **Original**: https://deriv-app-git-fork-heorhi-deriv-wall-4518-update-fiat-on-c00251.binary.sx
- **App ID**: `32691`

Copy link
Contributor

github-actions bot commented Sep 25, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 25
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-wall-4518-update-fiat-on-c00251.binary.sx/

@coveralls
Copy link

coveralls commented Sep 25, 2024

Coverage Status

coverage: 50.552% (-2.4%) from 52.986%
when pulling e9fe55d on heorhi-deriv:WALL-4518-Update-Fiat-Onramp-Implementation
into a9cb798 on binary-com:master.

Copy link

nijil-deriv
nijil-deriv previously approved these changes Sep 26, 2024
@coveralls
Copy link

coveralls commented Oct 1, 2024

Pull Request Test Coverage Report for Build 11177068868

Details

  • 17 of 60 (28.33%) changed or added relevant lines in 11 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 53.469%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/App/Containers/RealAccountSignup/add-currency-note.jsx 1 2 50.0%
packages/core/src/App/Containers/RealAccountSignup/choose-currency.js 1 2 50.0%
packages/core/src/App/Containers/RealAccountSignup/real-account-signup.jsx 1 2 50.0%
packages/wallets/src/features/cashier/modules/DepositCrypto/DepositCrypto.tsx 1 3 33.33%
packages/core/src/Stores/client-store.js 0 4 0.0%
packages/core/src/App/Containers/RealAccountSignup/add-crypto-currency.jsx 0 9 0.0%
packages/core/src/App/Containers/RealAccountSignup/choose-currency.jsx 0 25 0.0%
Files with Coverage Reduction New Missed Lines %
packages/core/src/Stores/client-store.js 1 0.0%
packages/core/src/App/Containers/RealAccountSignup/choose-currency.jsx 1 1.96%
Totals Coverage Status
Change from base Build 11176517853: -0.02%
Covered Lines: 34539
Relevant Lines: 60063

💛 - Coveralls

@nijil-deriv nijil-deriv merged commit 497efba into deriv-com:master Oct 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants