Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WALL] Lubega / WALL-3599 / CFD chevron design update #14474

Merged
merged 8 commits into from
Apr 4, 2024
Merged

[WALL] Lubega / WALL-3599 / CFD chevron design update #14474

merged 8 commits into from
Apr 4, 2024

Conversation

lubega-deriv
Copy link
Contributor

Changes:

  • Updated and restructured CFD accounts list to match chevron design
  • Updated existing unit tests
  • Updated cfd account cards to use quill icons
  • Added wheel event listener for wallets carousel

Screenshots:

image
Screen.Recording.2024-04-03.at.4.59.47.PM.mov
Screen.Recording.2024-04-03.at.4.59.06.PM.mov

@vercel Vercel
Copy link

vercel bot commented Apr 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Apr 4, 2024 10:37am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/14474](https://github.com/binary-com/deriv-app/pull/14474)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-3599-cfd-desktop-ch-dad7c1.binary.sx?qa_server=red.derivws.com&app_id=31524
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-3599-cfd-desktop-ch-dad7c1.binary.sx
- **App ID**: `31524`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 26
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-3599-cfd-desktop-ch-dad7c1.binary.sx/

@coveralls
Copy link

coveralls commented Apr 3, 2024 •
edited
Loading

Coverage Status

coverage: 39.921% (+0.01%) from 39.91%
when pulling 38ca149 on lubega-deriv:WALL-3599/cfd-desktop-chevron-design
into 3e8925f on binary-com:master.

azmib-developer
azmib-developer previously approved these changes Apr 4, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.4% Duplication on New Code

See analysis details on SonarCloud

@nijil-deriv nijil-deriv merged commit 992e0f9 into deriv-com:master Apr 4, 2024
6 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024 •
edited
Loading

⏳ Generating Lighthouse report...

@shahzaib-deriv shahzaib-deriv mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aizad-deriv aizad-deriv aizad-deriv left review comments

@azmib-developer azmib-developer azmib-developer approved these changes

@nijil-deriv nijil-deriv nijil-deriv approved these changes

@adrienne-deriv adrienne-deriv Awaiting requested review from adrienne-deriv

@thisyahlen-deriv thisyahlen-deriv Awaiting requested review from thisyahlen-deriv

@farhan-nurzi-deriv farhan-nurzi-deriv Awaiting requested review from farhan-nurzi-deriv

@heorhi-deriv heorhi-deriv Awaiting requested review from heorhi-deriv heorhi-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lubega-deriv @coveralls @nijil-deriv @aizad-deriv @azmib-developer