Generate alternatives for every git source

[jerbob92]

Fixes #3416

[jurre]

This makes a lot of sense to me, thanks. It would be awesome if we could add a test-case to verify this behavior and make sure that we don't regress in the future.

[jerbob92]

@jurre tests have been added, let me know what you think

[jurre]

It's not immediately clear to be what the first element of with_git_configured is, could we pull out a let that describes it?

let(:configured_git_config) { with_git_configured.first }
let(:configured_git_credentials) { with_git_configured.last }

Or even two separate lets, they don't need to be a subject

let(:configured_git_config) do
  Dependabot::SharedHelpers.with_git_configured(credentials: credentials) do
    `cat ~/.gitconfig`
  end
end

[jerbob92]

Yeah makes sense. What do you think of this:

def with_git_configured(&block)
  Dependabot::SharedHelpers.with_git_configured(credentials: credentials) { block.call }
end

let(:configured_git_config) { with_git_configured { `cat ~/.gitconfig` } }
let(:configured_git_credentials) { with_git_configured { `cat #{Dir.pwd}/git.store` } }

[jurre]

I dig it 👍 might need to pass in the credentials as an argument though, not sure if we can access it like that from a method

[jerbob92]

Well the tests pass locally so seems to work :)

[jurre]

This looks great, I'm commenting in-line with a few suggestions to make the tests a bit more readable but awesome work

[jurre]

✨ Thanks @jerbob92!

[feelepxyz]

👍