Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: add deoplete#sources#go#cgo_only config for disable go completion #161

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

zchee
Copy link
Member

@zchee zchee commented Dec 17, 2019

Add deoplete#sources#go#cgo_only config for disable go completion.

It useful for users want to use both gopls based lsp and deoplete-go.

It useful for users want to use both gopls based lsp and deoplete-go
@zchee zchee self-assigned this Dec 17, 2019
@Shougo
Copy link
Collaborator

Shougo commented Dec 17, 2019

Thank you!
It is merge-able?

@zchee
Copy link
Member Author

zchee commented Dec 17, 2019

@Shougo yep, already ready to merge.


BTW, in Go community, we has been stopped using gocode, we using gopls (Go core team maintains lsp server for Go). I think you already know, that's features are not only of completion. diag, lint and etc.

So, normally deoplete-go will be an archive project. But I want to continue to maintain. Bacause of there is no lsp server tht's support cgo completion with libclang at least now.

In other words, I planning to reinvent deoplete-go and make it a deoplete sources specialized for cgo completion in the future.
Also in addition, fortunately libclang's python binding has officially started to support python3.
What do you think about it?

@zchee
Copy link
Member Author

zchee commented Dec 17, 2019

ah, forgot one thing.

FYI, I was already pushed libclang v9.0.0 support branch (but still WIP)

https://github.com/deoplete-plugins/deoplete-go/tree/libclang/v9.0.0

@Shougo Shougo merged commit dffbe97 into master Dec 17, 2019
@Shougo
Copy link
Collaborator

Shougo commented Dec 17, 2019

OK. Merged.

FYI, I was already pushed libclang v9.0.0 support branch (but still WIP)

I will merge it if it is completed.

So, normally deoplete-go will be an archive project. But I want to continue to maintain. Bacause of there is no lsp server tht's support cgo completion with libclang at least now.

Hm. OK. I think it should be documented.

In other words, I planning to reinvent deoplete-go and make it a deoplete sources specialized for cgo completion in the future.

It seems nice. deoplete-cgo?

Also in addition, fortunately libclang's python binding has officially started to support python3.

Python3 is better. Python2 is deprecated.

@Shougo
Copy link
Collaborator

Shougo commented Dec 17, 2019

Ah, please add deoplete#sources#go#cgo_only documentation.

@zchee
Copy link
Member Author

zchee commented Dec 19, 2019

@Shougo I see, will do (maybe tonight)

@zchee zchee deleted the add-cgo-only branch January 26, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants