Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(io): readDelim returns wrong result if delim strides over chunks #877

Merged
merged 7 commits into from
May 14, 2021

Conversation

keroxp
Copy link
Contributor

@keroxp keroxp commented Apr 24, 2021

@kfdf
Copy link

kfdf commented Apr 25, 2021

Nice to see the issue #803 is being handled, but as I mentiond before, the createLPS function is still bugged. This causes an infinite loop:

import { readStringDelim } from 'https://deno.land/[email protected]/io/mod.ts'
readStringDelim(null, '1213').next()

As may the use of very long delimiters (longer than 256 bytes).

@keroxp
Copy link
Contributor Author

keroxp commented Apr 25, 2021

@kfdf Oh, that's true! Also fixed on 82b327a

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keroxp Thank you for the fix! LGTM

@kfdf Thank you for your review!

@kt3k kt3k merged commit 24e77f8 into denoland:main May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants