Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(assert): add note and example for Blob comparison #6210

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

IgorM867
Copy link
Contributor

This PR improves the documentation for the assertEquals function by addressing how to compare Blob objects.

Fixes #6202

@IgorM867 IgorM867 requested a review from kt3k as a code owner November 25, 2024 15:31
@IgorM867 IgorM867 changed the title doc(assert): add note and example for Blob comparison docs(assert): add note and example for Blob comparison Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.52%. Comparing base (ddda6bd) to head (acac955).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6210   +/-   ##
=======================================
  Coverage   96.52%   96.52%           
=======================================
  Files         534      534           
  Lines       40922    40922           
  Branches     6131     6131           
=======================================
+ Hits        39499    39502    +3     
+ Misses       1381     1378    -3     
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit c78f6a5 into denoland:main Nov 26, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assertEquals doesn't correctly compare Blobs
2 participants