Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run @example JSDoc code snippets #4669

Merged
merged 8 commits into from
May 6, 2024
Merged

chore: run @example JSDoc code snippets #4669

merged 8 commits into from
May 6, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented May 2, 2024

This ensures that our code snippets are correct. Once this is merged, we'll have to rewrite some documents to take advantage of assertions.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.36%. Comparing base (e7ce4ff) to head (d39e7da).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4669   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files         477      477           
  Lines       37334    37334           
  Branches     5325     5325           
=======================================
  Hits        34109    34109           
  Misses       3164     3164           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua marked this pull request as ready for review May 6, 2024 01:30
@iuioiua iuioiua requested a review from kt3k as a code owner May 6, 2024 01:30
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 4bdefc1 into main May 6, 2024
13 checks passed
@iuioiua iuioiua deleted the run-code-snippets branch May 6, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants