add encoding/hex module #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
May 23, 2019
ry
reviewed
May 23, 2019
|
@axetroy what's the status of this PR? Is it ready? |
kitsonk
reviewed
Jun 6, 2019
encoding/hex.ts
Outdated
| * DecodeString returns the bytes represented by the hexadecimal string `s`. | ||
| * DecodeString expects that src contains only hexadecimal characters and that src has even length. | ||
| * If the input is malformed, DecodeString will throws an error. | ||
| * @param s |
There was a problem hiding this comment.
You only need to add this if you are actually going to add a comment about the argument, otherwise I would just omit it as it adds nothing.
The merge the part of hex module first and the rest are waiting for other modules to be completed. So I think it is ready for review. |
ry
reviewed
Jun 6, 2019
encoding/hex.ts
Outdated
| // Use of this source code is governed by a BSD-style | ||
| // license that can be found in the LICENSE file. | ||
| // Copyright 2018-2019 the Deno authors. All rights reserved. MIT license. | ||
| // import { copyBytes } from "../io/util.ts"; |
encoding/hex.ts
Outdated
| // import { copyBytes } from "../io/util.ts"; | ||
|
|
||
| const hextable = new TextEncoder().encode("0123456789abcdef"); | ||
| // const bufferSize = 1024; |
encoding/hex.ts
Outdated
|
|
||
| /** | ||
| * Encode encodes `src` into `encodedLen(src.length)` bytes of `dst`. | ||
| * As a convenience, it returns the number of bytes written to `dst`, but this value is always `encodedLen(src.length)`. |
| for (let i = 0; i < src.length; i++) { | ||
| const v = src[i]; | ||
| dst[i * 2] = hextable[v >> 4]; | ||
| dst[i * 2 + 1] = hextable[v & 0x0f]; |
There was a problem hiding this comment.
Is this reading a Int16 ?
Consider using https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Int16Array
encoding/hex.ts
Outdated
|
|
||
| // return n; | ||
| // } | ||
| // } |
ry
pushed a commit
to ry/deno
that referenced
this pull request
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://golang.org/pkg/encoding/hex , #431