Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ws: make acceptable() more robust #404

Merged
merged 1 commit into from
May 14, 2019
Merged

ws: make acceptable() more robust #404

merged 1 commit into from
May 14, 2019

Conversation

ry
Copy link
Member

@ry ry commented May 14, 2019 •
edited
Loading

cc @keroxp

@ry ry requested a review from piscisaureus May 14, 2019 16:12
keroxp
keroxp reviewed May 14, 2019
View reviewed changes
Copy link
Contributor

@keroxp keroxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

ws/mod.ts Show resolved Hide resolved
piscisaureus
piscisaureus approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry force-pushed the ws_acceptable branch from a074287 to bf3afcd Compare May 14, 2019 21:42
@ry ry merged commit 9e8e6f9 into denoland:master May 14, 2019
ry added a commit to ry/deno that referenced this pull request Oct 9, 2019
@ry
ws: make acceptable() more robust (denoland/std#404)
9f877cd 
Original: denoland/std@9e8e6f9
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this pull request Oct 24, 2024
@iuioiua
fix: omit Stripe vars from .example.env (denoland#404)
df48c06 
Fixes denoland#403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keroxp keroxp keroxp left review comments

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ry @piscisaureus @keroxp