Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(node): update domain names in dns test #2881

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Nov 12, 2022

This PR updates the domain name _jabber._tcp.google.com to _caldav._tcp.google.com in test-dns-any.js (in node compat testing). _jabber._tcp.google.com seems to have stopped working recently. _caldav._tcp.google.com seems still working.

@kt3k kt3k force-pushed the test-node-update-domains branch from 166ee82 to 776d801 Compare November 12, 2022 12:19
@kt3k kt3k force-pushed the test-node-update-domains branch from 776d801 to e7f25a3 Compare November 12, 2022 12:19
@kt3k
Copy link
Member Author

kt3k commented Nov 12, 2022

currently blocked by #2882 resolved

@kt3k kt3k requested review from bartlomieju and cjihrig November 13, 2022 10:46
@kt3k kt3k merged commit c5b6033 into denoland:main Nov 13, 2022
@kt3k kt3k deleted the test-node-update-domains branch November 13, 2022 13:45
cjihrig added a commit to cjihrig/node that referenced this pull request Nov 13, 2022
_jabber._tcp.google.com seems to have stopped working. This
commit changes the host to _caldav._tcp.google.com.

Refs: denoland/std#2881
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Nov 15, 2022
_jabber._tcp.google.com seems to have stopped working. This
commit changes the host to _caldav._tcp.google.com.

Refs: denoland/std#2881
PR-URL: #45451
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
ruyadorno pushed a commit to nodejs/node that referenced this pull request Nov 21, 2022
_jabber._tcp.google.com seems to have stopped working. This
commit changes the host to _caldav._tcp.google.com.

Refs: denoland/std#2881
PR-URL: #45451
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit to nodejs/node that referenced this pull request Dec 30, 2022
_jabber._tcp.google.com seems to have stopped working. This
commit changes the host to _caldav._tcp.google.com.

Refs: denoland/std#2881
PR-URL: #45451
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit to nodejs/node that referenced this pull request Dec 30, 2022
_jabber._tcp.google.com seems to have stopped working. This
commit changes the host to _caldav._tcp.google.com.

Refs: denoland/std#2881
PR-URL: #45451
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit to nodejs/node that referenced this pull request Jan 3, 2023
_jabber._tcp.google.com seems to have stopped working. This
commit changes the host to _caldav._tcp.google.com.

Refs: denoland/std#2881
PR-URL: #45451
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit to nodejs/node that referenced this pull request Jan 4, 2023
_jabber._tcp.google.com seems to have stopped working. This
commit changes the host to _caldav._tcp.google.com.

Refs: denoland/std#2881
PR-URL: #45451
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants