Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): Allow Passing the exact same path and domain attributes while removing cookies #1005

Merged
merged 4 commits into from
Jul 6, 2021

Conversation

getspooky
Copy link
Contributor

No description provided.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @getspooky, does it fix some concrete problem?

http/cookie_test.ts Outdated Show resolved Hide resolved
@getspooky
Copy link
Contributor Author

@bartlomieju let's say

setCookie({ headers }, { name: "deno", value: "cat"});
setCookie({ headers }, { name: "deno", value: "cat", path: "/demo" });

if we run

deleteCookie({ headers }, "deno");

it will not remove both cookies , so the puporse of this PR is to provide a way to remove cookie by specify path or domain.

for example

deleteCookie({ headers }, "deno", { path: "/demo" });

@getspooky getspooky requested a review from bartlomieju July 6, 2021 17:40
@bartlomieju bartlomieju merged commit d8e61e4 into denoland:main Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants