fix(encoding/toml): serializes mixed array #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I think your unit tests fail to account for the fact that object keys aren't necessarily ordered :) (also make sure you run |
bartlomieju
reviewed
Jul 6, 2021
encoding/toml.ts
Outdated
| class Dumper { | ||
| maxPad = 0; | ||
| srcObject: Record<string, unknown>; | ||
| output: string[] = []; | ||
| _arrayTypeCache = new Map<unknown[], ArrayType>(); |
There was a problem hiding this comment.
I suggest to use private field (prefixed with # instead of _)
There was a problem hiding this comment.
👌 Do you think we should update methods starting with _ too? Maybe for the whole project?
There was a problem hiding this comment.
I think we should use # for methods too (at least for Dumper class).
encoding/toml_test.ts
Outdated
Comment on lines
431
to
440
| mixedArray1: [1, { b: 2 }], | ||
| mixedArray2: [{ b: 2 }, 1], | ||
| nestedArray1: [[{ b: 1 }]], | ||
| nestedArray2: [[[{ b: 1 }]]], | ||
| deepNested: { | ||
| a: { | ||
| b: [1, { c: 2, d: [{ e: 3 }, true] }], | ||
| }, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Make sure that this test exercises all variants from ArrayType enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #983
Previously, arrays are assumed to be homogenous, but that is not the case (or it is changed recently?).
https://github.com/toml-lang/toml/blob/master/toml.md#user-content-array