feat: provide full import statement range #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't know what caused this: |
|
Bug fix: denoland/deno#25860 |
dsherret
reviewed
Oct 8, 2024
| @@ -172,6 +174,7 @@ pub struct DynamicDependencyDescriptor { | |||
| pub argument: DynamicArgument, | |||
| /// The range of the argument. | |||
| pub argument_range: PositionRange, | |||
| pub range: PositionRange, | |||
There was a problem hiding this comment.
I just realized this breaks the deserialization of information we store on JSR. We'll need to think of a solution for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
Import::rangetoImport::specifier_range, addsImport::full_range.Towards denoland/deno#18884.