Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime): stabilise permissions and add event target capabilities #9573

Merged
merged 4 commits into from
Feb 25, 2021

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Feb 22, 2021

This stabilises permissions under the Deno namespace and adds back the event target features that were reverted prior to Deno 1.2.

Since Deno permission descriptors will never intersect with navigator permissions and the web standard has left request and revoke out of the APIs, but they are very useful for Deno use cases, it makes sense to align the APIs to the spirit of the web standard but keep them part of the Deno namespace, as they are the only place where they can be reliably used.

Stabilising the APIs provides the advantage of allow people to make interactive CLI applications (and use permission management libraries) in Deno without the need of the --unstable flag, which leads to a better experience when building tools for others.

@kitsonk kitsonk requested a review from bartlomieju February 22, 2021 06:11
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

cli/tests/unit/permissions_test.ts Show resolved Hide resolved
@kitsonk kitsonk merged commit 097e9c4 into denoland:main Feb 25, 2021
@kitsonk kitsonk deleted the feat_stabilise_permissions branch February 25, 2021 03:33
@kitsonk kitsonk mentioned this pull request Feb 25, 2021
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants