-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(outdated): show a suggestion for updating #27304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -100,6 +100,24 @@ fn print_outdated_table(packages: &[OutdatedPackage]) { | |||
println!("└{package_fill}┴{current_fill}┴{update_fill}┴{latest_fill}┘",); | |||
} | |||
|
|||
#[allow(clippy::print_stdout)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should use log::info
for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I think we should use log::info
instead.
I believe this is the same situation as with
So I think it's fine to use |
I don't think this is vital to the main information being displayed though. |
Show command to update dependencies based on the output of "deno outdated" command. Closes #27256
Show command to update dependencies based on the output
of "deno outdated" command.
Closes #27256