Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(outdated): show a suggestion for updating #27304

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

bartlomieju
Copy link
Member

Show command to update dependencies based on the output
of "deno outdated" command.

Screenshot 2024-12-10 at 03 10 31

Closes #27256

Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -100,6 +100,24 @@ fn print_outdated_table(packages: &[OutdatedPackage]) {
println!("└{package_fill}┴{current_fill}┴{update_fill}┴{latest_fill}┘",);
}

#[allow(clippy::print_stdout)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use log::info for this?

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we should use log::info instead.

@bartlomieju
Copy link
Member Author

LGTM, but I think we should use log::info instead.

I believe this is the same situation as with deno lint --rules which has this comment:

// The rules should still be printed even if --quiet option is enabled,
// so use println! here instead of info!.

So I think it's fine to use println! here

@bartlomieju bartlomieju merged commit c3af098 into denoland:main Dec 10, 2024
17 checks passed
@bartlomieju bartlomieju deleted the outdated_output branch December 10, 2024 13:41
@dsherret
Copy link
Member

I don't think this is vital to the main information being displayed though.

bartlomieju added a commit that referenced this pull request Dec 11, 2024
Show command to update dependencies based on the output
of "deno outdated" command.

Closes #27256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno outdated should suggest action
3 participants