fix(compile): correct read length for transpiled typescript files #27301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 10, 2024
dsherret
commented
Dec 10, 2024
There was a problem hiding this comment.
As noted in the PR description, I don't have a test for this in this PR because it's hard to reproduce, but there is a scenario in another PR I'm going to land that reproduces it.
dsherret
commented
Dec 10, 2024
| } | ||
| VfsFileSubDataKind::ModuleGraph => { | ||
| virtual_file.module_graph_offset = offset; | ||
| virtual_file.module_graph_offset = offset_and_len; |
There was a problem hiding this comment.
This data length was previously not being stored.
bartlomieju
approved these changes
Dec 10, 2024
bartlomieju
pushed a commit
that referenced
this pull request
Dec 11, 2024
…7301) Extracted out of https://github.com/denoland/deno/pull/27296/files It's hard to test for this, but a test for this is in that other PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted out of https://github.com/denoland/deno/pull/27296/files
It's hard to test for this, but a test for this is in that other PR.