feat(unstable): support caching npm dependencies only as they're needed #27300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwhit
force-pushed
the
package-json-autoinstall
branch
from
e3ada55 to
03c5334
Compare
dsherret
reviewed
Dec 10, 2024
| GraphKind::All, | ||
| roots.clone(), | ||
| &mut loader, | ||
| graph_util::NpmCachingStrategy::Eager, |
There was a problem hiding this comment.
I feel like maybe we could maybe get away with setting this as lazy in the lsp or just only install stuff found in the package.json, deno.json, or any specifiers.
Co-authored-by: Luca Casonato <[email protected]> Signed-off-by: Nathan Whitaker <[email protected]>
nathanwhit
force-pushed
the
package-json-autoinstall
branch
from
b7c7b2a to
9bc0da0
Compare
bartlomieju
pushed a commit
that referenced
this pull request
Dec 11, 2024
…ed (#27300) Currently deno eagerly caches all npm packages in the workspace's npm resolution. So, for instance, running a file `foo.ts` that imports `npm:chalk` will also install all dependencies listed in `package.json` and all `npm` dependencies listed in the lockfile. This PR refactors things to give more control over when and what npm packages are automatically cached while building the module graph. After this PR, by default the current behavior is unchanged _except_ for `deno install --entrypoint`, which will only cache npm packages used by the given entrypoint. For the other subcommands, this behavior can be enabled with `--unstable-npm-lazy-caching` Fixes #25782. --------- Signed-off-by: Nathan Whitaker <[email protected]> Co-authored-by: Luca Casonato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently deno eagerly caches all npm packages in the workspace's npm resolution. So, for instance, running a file
foo.tsthat importsnpm:chalkwill also install all dependencies listed inpackage.jsonand allnpmdependencies listed in the lockfile.This PR refactors things to give more control over when and what npm packages are automatically cached while building the module graph.
After this PR, by default the current behavior is unchanged except for
deno install --entrypoint, which will only cache npm packages used by the given entrypoint. For the other subcommands, this behavior can be enabled with--unstable-npm-lazy-cachingTODO:
Fixes #25782.