Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unstable): don't unwrap optional state in otel #27292

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Dec 9, 2024

otel global state may not be initialized if otel is not enabled, so bail out instead of panicking.

Fixes: #27272

Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devsnek devsnek merged commit 1c0f236 into main Dec 9, 2024
17 checks passed
@devsnek devsnek deleted the x/fix-otel-panics branch December 9, 2024 21:33
bartlomieju pushed a commit that referenced this pull request Dec 11, 2024
otel global state may not be initialized if otel is not enabled, so bail
out instead of panicking.

Fixes: #27272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno panics while serving otel example
2 participants