Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): attach console stream properties #25617

Merged
merged 1 commit into from
Sep 14, 2024
Merged

fix(ext/node): attach console stream properties #25617

merged 1 commit into from
Sep 14, 2024

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Sep 13, 2024

kBindStreamsLazy should be called with process during init, but it never was.

@devsnek devsnek requested a review from bartlomieju September 13, 2024 16:33
satyarohith
satyarohith reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a small test for the fix

nathanwhit
nathanwhit approved these changes Sep 14, 2024
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devsnek devsnek merged commit 2c0bf6f into main Sep 14, 2024
17 checks passed
@devsnek devsnek deleted the x/console-node-props branch September 14, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satyarohith satyarohith satyarohith left review comments

@nathanwhit nathanwhit nathanwhit approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devsnek @nathanwhit @satyarohith