Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): fix Decipheriv when autoPadding disabled #25598

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Sep 12, 2024

This PR fixes Decipheriv behavior when autoPadding disabled and enabled.

By this change, the example given in this comment works in the same way as Node.

closes #20924

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 3f15e30 into denoland:main Sep 12, 2024
17 checks passed
@kt3k kt3k deleted the fix-ext-node-decipher-auto-pad-disabled branch September 12, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node-compat: npm:oracledb(thin mode)
3 participants