Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node/byonm): do not accidentally resolve bare node built-ins #25543

Merged
merged 2 commits into from
Sep 9, 2024
Merged

fix(node/byonm): do not accidentally resolve bare node built-ins #25543

merged 2 commits into from
Sep 9, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Sep 9, 2024

This was accidentally enabled in byonm, but it requires the --unstable-bare-node-builtins flag.

Closes #25358

bartlomieju
bartlomieju approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs a rebase

@dsherret dsherret enabled auto-merge (squash) September 9, 2024 21:00
@dsherret dsherret merged commit 560ad03 into denoland:main Sep 9, 2024
17 checks passed
@dsherret dsherret deleted the fix_byonm_bare_node_builtin branch October 1, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bare node builtin support accidentally works with byonm
2 participants
@dsherret @bartlomieju