Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(add): Add npm packages to package.json if present #25477

Merged
merged 9 commits into from
Sep 6, 2024

Conversation

nathanwhit
Copy link
Member

Closes #25321

Ended up being a larger refactoring, since we're now juggling (potentially) two config files in the same add, instead of choosing one. I don't love the shape of the code, but I think it's good enough

Some smaller side improvements:

  • deno remove supports jsonc
  • deno install --dev will be a really simple change
  • if deno remove removes the last import/dependency in the imports/dependencies/devDependencies field, it removes the field instead of leaving an empty object

@nathanwhit nathanwhit requested a review from dsherret September 5, 2024 22:58
@bartlomieju
Copy link
Member

deno install --dev will be a really simple change

I don't see a test for that so I assume this will be done in a follow up?

@nathanwhit nathanwhit enabled auto-merge (squash) September 6, 2024 16:43
@nathanwhit nathanwhit merged commit 51f5f57 into denoland:main Sep 6, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option for deno add to update package.json for npm packages
2 participants