Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(add): strip package subpath when adding a package #25419

Merged
merged 4 commits into from
Sep 4, 2024
Merged

feat(add): strip package subpath when adding a package #25419

merged 4 commits into from
Sep 4, 2024

Conversation

bartlomieju
Copy link
Member

These now works:

$ deno add @std/dotenv/load
$ deno add npm:preact/hooks

Previously we were erroring out, because this is a "package reference" including
a subpath.

Closes #25385

marvinhagemeister
marvinhagemeister approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

dsherret
dsherret approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/tools/registry/pm.rs Outdated Show resolved Hide resolved
cli/tools/registry/pm.rs Outdated Show resolved Hide resolved
bartlomieju and others added 2 commits September 4, 2024 14:20
@bartlomieju @dsherret
Update cli/tools/registry/pm.rs
75b8dff 
Co-authored-by: David Sherret <[email protected]>
Signed-off-by: Bartek Iwańczuk <[email protected]>
@bartlomieju @dsherret
Update cli/tools/registry/pm.rs
a4c4d29 
Co-authored-by: David Sherret <[email protected]>
Signed-off-by: Bartek Iwańczuk <[email protected]>
@bartlomieju bartlomieju enabled auto-merge (squash) September 4, 2024 12:20
@bartlomieju bartlomieju merged commit c58a628 into denoland:main Sep 4, 2024
17 checks passed
@bartlomieju bartlomieju deleted the pm_strip_subpath_when_adding branch September 4, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running deno add @std/dotenv/load should just work
3 participants
@bartlomieju @marvinhagemeister @dsherret