fix(byonm): resolve npm deps of jsr deps #25399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… node resolution for byonm
dsherret
force-pushed
the
fix_install_npm_deps_of_jsr_deps
branch
from
27a8128 to
3346d06
Compare
bartlomieju
reviewed
Sep 4, 2024
bartlomieju
approved these changes
Sep 4, 2024
dsherret
added a commit
that referenced
this pull request
Sep 9, 2024
This was initially added in #25399 in order to make transitioning over from package.json to deno.json more easy, but it causes some problems that are shown in the issue and it also means that the output of `deno install` would have different resolution than `npm install`. Overall, I think it's too much complexity to be smarter about this and it's probably best to not do it. If someone needs an aliased folder then they should keep using a package.json Closes #25538
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using npm deps of jsr deps without having to add them to the root package.json.
Works by taking the package requirement and scanning the
node_modules/.denodirectory for the best matching package, so it relies on deno's node_modules structure.Additionally to make the transition from package.json to deno.json easier, Deno now:
node_modules/<alias>for better package.json compatiblity.