Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upgrade): support RC release with --version flag #25091

Merged
merged 3 commits into from
Aug 19, 2024
Merged

fix(upgrade): support RC release with --version flag #25091

merged 3 commits into from
Aug 19, 2024

Conversation

bartlomieju
Copy link
Member

This commit fixes scenarios like:

$ deno upgrade --version=v1.46.0-rc.0
Downloading https://github.com/denoland/deno/releases/download/v1.46.0-rc.0/deno-aarch64-apple-darwin.zip
Download could not be found, aborting

Now:

$ target/debug/deno upgrade --version=v1.46.0-rc.0
Downloading https://dl.deno.land/release/v1.46.0-rc.0/deno-aarch64-apple-darwin.zip
Deno is upgrading to version 1.46.0-rc.0

Upgraded successfully to Deno v1.46.0-rc.0

Also some unneeded code was removed.

@bartlomieju bartlomieju requested a review from dsherret August 18, 2024 23:36
@bartlomieju bartlomieju enabled auto-merge (squash) August 19, 2024 00:14
@bartlomieju bartlomieju merged commit 5c69b48 into denoland:main Aug 19, 2024
17 checks passed
@bartlomieju bartlomieju deleted the fix_upgrade_support_rc_in_version branch August 19, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @dsherret