Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upgrade): correctly compute latest version based on current release channel #25087

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

bartlomieju
Copy link
Member

This commit fixes computation of the latest available version
by taking into account which release channel the current
binary is on.

Before this commit, if user was on "RC" channel, calling
deno upgrade would not switch back to the "stable"
channel.

@bartlomieju bartlomieju requested a review from dsherret August 18, 2024 21:26
@bartlomieju bartlomieju added this to the 1.46 milestone Aug 18, 2024
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit f003d64 into denoland:main Aug 18, 2024
17 checks passed
@bartlomieju bartlomieju deleted the upgrade_release_channel branch August 18, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants