Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): resolve jsx import source with types mode #25064

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

nayeemrmn
Copy link
Collaborator

Blocked on denoland/deno_graph#513.

Fixes jsx import sources with alternate resolutions for types. Also fixes panic from trying to cache npm specifiers as roots under byonm.

@nayeemrmn nayeemrmn marked this pull request as ready for review August 21, 2024 11:13
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit c22ff19 into denoland:main Aug 21, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-jsx-types-byonm branch August 21, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants