Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(temporal/unstable): Remove obsoleted Temporal APIs #24836

Merged

Conversation

petamoriken
Copy link
Contributor

@petamoriken petamoriken commented Aug 1, 2024

At the TC39 meeting on 2024-06, it was decided to obsolete several Temporal APIs. I have disabled those APIs that had already been removed from the specification.
Ref tc39/proposal-temporal#2895, tc39/proposal-temporal#2914

Temporal.TimeZone and Temporal.Calendar are also obsoleted, so I will remove them as well when they are removed from the specification.
Ref tc39/proposal-temporal#2925

@petamoriken petamoriken force-pushed the fix/remove-obsoleted-temporal-api branch 2 times, most recently from 5e18936 to f3e7a70 Compare August 2, 2024 00:52
@petamoriken petamoriken force-pushed the fix/remove-obsoleted-temporal-api branch from f3e7a70 to 28a37ad Compare August 2, 2024 00:54
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucacasonato lucacasonato merged commit d2b66e5 into denoland:main Aug 2, 2024
17 checks passed
@petamoriken petamoriken deleted the fix/remove-obsoleted-temporal-api branch August 2, 2024 11:07
bartlomieju pushed a commit that referenced this pull request Sep 10, 2024
…25505)

Mainly I removed `Temporal.Calendar` and `Temporal.TimeZone` and
replaced them to APIs that handle calendar and timezone as strings.
tc39/proposal-temporal#2925

Related #24836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants