Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CFunctionInfo and CTypeInfo leaks #24634

Merged
merged 5 commits into from
Jul 21, 2024
Merged

fix: CFunctionInfo and CTypeInfo leaks #24634

merged 5 commits into from
Jul 21, 2024

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Jul 18, 2024 •
edited by bartlomieju
Loading

Trying out the deno_core patch

Ref denoland/deno_core#832

Closes #24575

@bartlomieju bartlomieju mentioned this pull request Jul 19, 2024
Closed
@bartlomieju
Copy link
Member

Added changes from #24597 that updates API using deprecated SourceMapGetter API.

@bartlomieju bartlomieju mentioned this pull request Jul 19, 2024
Closed
bartlomieju
bartlomieju approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju
Copy link
Member

Appears this has regressed on the source map changes.

I'm erring on the side of reverting all changes related to source maps in deno_core for now, unless we can figure out what's wrong today.

@bartlomieju
Copy link
Member

Actually it's not a regression. This should be fine to land as is.

@bartlomieju bartlomieju merged commit 6c5905d into denoland:main Jul 21, 2024
17 checks passed
@bartlomieju bartlomieju deleted the fix_opctx_leak branch July 21, 2024 01:05
bartlomieju added a commit to bartlomieju/deno that referenced this pull request Jul 22, 2024
@bartlomieju
Revert "fix: CFunctionInfo and CTypeInfo leaks (denoland#24634)"
870cec0 
This reverts commit 6c5905d.
bartlomieju added a commit that referenced this pull request Jul 22, 2024
@bartlomieju
Revert "fix: CFunctionInfo and CTypeInfo leaks (#24634)" (#24665)
95847f4 
This reverts commit 6c5905d.

Reverting because of errors like this in CI:
```
#
# Fatal error in , line 0
# Check failed: FastApiCallNode::ArityForArgc(c_arg_count, slow_arg_count) == value_input_count.
#
#
#
#FailureMessage Object: 0x7fd5b3ffd9d0
==== C stack trace ===============================

    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x1111883) [0x55b8d2107883]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x1110b6b) [0x55b8d2106b6b]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x110c6f9) [0x55b8d21026f9]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x20413cd) [0x55b8d30373cd]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x2034222) [0x55b8d302a222]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x202ff44) [0x55b8d3025f44]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x1e0b253) [0x55b8d2e01253]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x1dfcd96) [0x55b8d2df2d96]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x1df92aa) [0x55b8d2def2aa]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x1df8b71) [0x55b8d2deeb71]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x11ce49b) [0x55b8d21c449b]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x121fb23) [0x55b8d2215b23]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x1221359) [0x55b8d2217359]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x1112f3b) [0x55b8d2108f3b]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x111792b) [0x55b8d210d92b]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x110df0f) [0x55b8d2103f0f]
    /lib/x86_64-linux-gnu/libc.so.6(+0x94ac3) [0x7fd5cb294ac3]
    /lib/x86_64-linux-gnu/libc.so.6(+0x126850) [0x7fd5cb326850]
```
bartlomieju added a commit that referenced this pull request Jul 22, 2024
@littledivy @bartlomieju
fix: CFunctionInfo and CTypeInfo leaks (#24634)
e10e981 
Trying out the deno_core patch

Ref denoland/deno_core#832

Closes #24575

---------

Co-authored-by: Bartek Iwańczuk <[email protected]>
bartlomieju added a commit that referenced this pull request Jul 22, 2024
@bartlomieju
Revert "fix: CFunctionInfo and CTypeInfo leaks (#24634)" (#24665)
b5e5e1d 
This reverts commit 6c5905d.

Reverting because of errors like this in CI:
```
#
# Fatal error in , line 0
# Check failed: FastApiCallNode::ArityForArgc(c_arg_count, slow_arg_count) == value_input_count.
#
#
#
#FailureMessage Object: 0x7fd5b3ffd9d0
==== C stack trace ===============================

    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x1111883) [0x55b8d2107883]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x1110b6b) [0x55b8d2106b6b]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x110c6f9) [0x55b8d21026f9]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x20413cd) [0x55b8d30373cd]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x2034222) [0x55b8d302a222]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x202ff44) [0x55b8d3025f44]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x1e0b253) [0x55b8d2e01253]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x1dfcd96) [0x55b8d2df2d96]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x1df92aa) [0x55b8d2def2aa]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x1df8b71) [0x55b8d2deeb71]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x11ce49b) [0x55b8d21c449b]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x121fb23) [0x55b8d2215b23]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x1221359) [0x55b8d2217359]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x1112f3b) [0x55b8d2108f3b]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x111792b) [0x55b8d210d92b]
    /home/runner/work/deno/deno/target/release/deps/url_ops-e4068c650cedb9fa(+0x110df0f) [0x55b8d2103f0f]
    /lib/x86_64-linux-gnu/libc.so.6(+0x94ac3) [0x7fd5cb294ac3]
    /lib/x86_64-linux-gnu/libc.so.6(+0x126850) [0x7fd5cb326850]
```
bartlomieju added a commit to bartlomieju/deno that referenced this pull request Jul 23, 2024
@bartlomieju
Revert "Revert "fix: CFunctionInfo and CTypeInfo leaks (denoland#24634)…
058d803 
…" (denoland#24665)"

This reverts commit 95847f4.
bartlomieju added a commit that referenced this pull request Jul 24, 2024
@bartlomieju
Reland "fix: CFunctionInfo and CTypeInfo leaks (#24634)" (#24692)
445e05a 
Reverted in
95847f4.
@matthew-wong1 matthew-wong1 mentioned this pull request Jul 28, 2024
Closed
dsherret pushed a commit that referenced this pull request Jul 26, 2024
@bartlomieju @dsherret
Reland "fix: CFunctionInfo and CTypeInfo leaks (#24634)" (#24692)
57e0f40 
Reverted in
95847f4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible memory leak when using Deno to run trivial JavaScript (Linux)
2 participants
@littledivy @bartlomieju