fix(node): Run node compat tests listed in the ignore field (and fix the ones that fail)
#24631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwhit
changed the title
ignore field of tests/node_compat/config.jsoncignore field of node compat tests config
nathanwhit
force-pushed
the
node-compat-suite-run-ignore
branch
from
b4e6711 to
bb7e7fb
Compare
marvinhagemeister
approved these changes
Jul 18, 2024
nathanwhit
changed the title
ignore field of node compat tests configignore field (and fix the ones that fail)
dsherret
pushed a commit
that referenced
this pull request
Jul 26, 2024
…x the ones that fail) (#24631) The intent is that those tests will be executed, but our check that the files are up to date won't overwrite the contents of the tests. This is useful when a test needs some manual edits to work. It turns out we weren't actually running them. --- This ended up turning into a couple of small bug fixes to get the tests passing: - We weren't canonicalizing the exec path properly (it sometimes still had `..` or `.` in it) - We weren't accepting strings in `process.exit` There was one failure I couldn't figure out quickly, so I disabled the test for now, and filed a follow up issue: #24694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent is that those tests will be executed, but our check that the files are up to date won't overwrite the contents of the tests. This is useful when a test needs some manual edits to work.
It turns out we weren't actually running them.
This ended up turning into a couple of small bug fixes to get the tests passing:
..or.in it)process.exitThere was one failure I couldn't figure out quickly, so I disabled the test for now, and filed a follow up issue: #24694