refactor: remove serde_json::Value from inspector #14258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Apr 12, 2022
lucacasonato
force-pushed
the
repl_console_log_panic
branch
3 times, most recently
from
8cd28ac to
9ee8f4e
Compare
This commit removes the `serde_json::Value` intermediary from the `LocalInspectorSession`. This is done as preparatory work for fixing the error that occurs when the REPL evaluates an expression that returns a string that contains invalid surrogates sequences. As a side-effect to the changes to the parsing of notifications, this fixes the panic that occurs in the REPL when logging strings containing lone surrogates. This does not yet resolve the error when a REPL expression returns a string that contains lone surrogates.
lucacasonato
force-pushed
the
repl_console_log_panic
branch
from
9ee8f4e to
2bbf9ba
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
serde_json::Valueintermediary from theLocalInspectorSession. This is done as preparatory work for fixing theerror that occurs when the REPL evaluates an expression that returns a
string that contains invalid surrogates sequences.
As a side-effect to the changes to the parsing of notifications, this
fixes the panic that occurs in the REPL when logging strings
containing lone surrogates. This does not yet resolve the error when a
REPL expression returns a string that contains lone surrogates.
TODO:
Fixes #12226