Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: factor out CDP message types #13501

Merged
merged 11 commits into from
Jan 27, 2022
Merged

refactor: factor out CDP message types #13501

merged 11 commits into from
Jan 27, 2022

Conversation

crowlKats
Copy link
Member

No description provided.

bartlomieju
bartlomieju reviewed Jan 26, 2022
View reviewed changes
cli/inspector_structures.rs Outdated Show resolved Hide resolved
cli/tools/coverage/mod.rs Outdated Show resolved Hide resolved
cli/tools/repl/channel.rs Outdated Show resolved Hide resolved
cli/inspector_structures.rs Outdated Show resolved Hide resolved
lucacasonato
lucacasonato approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju
Copy link
Member

Maybe rename to refactor: factor out CDP message types?

@ry
Copy link
Member

ry commented Jan 27, 2022

What does this feature do?

@crowlKats crowlKats changed the title feat(cli): Devtools Protocol Structs refactor: factor out CDP message types Jan 27, 2022
@bartlomieju
Copy link
Member

What does this feature do?

Not a feature, refactor that is a prerequisite for #12899

@crowlKats crowlKats merged commit 382a978 into denoland:main Jan 27, 2022
@crowlKats crowlKats deleted the inspector_structs branch January 27, 2022 14:09
bartlomieju pushed a commit that referenced this pull request Jan 27, 2022
@crowlKats @bartlomieju
refactor: factor out CDP message types (#13501)
0773faa
@bartlomieju bartlomieju mentioned this pull request Jan 30, 2022
Closed
bartlomieju added a commit to bartlomieju/deno that referenced this pull request Jan 30, 2022
@bartlomieju
Revert "refactor: factor out CDP message types (denoland#13501)"
95095c2 
This reverts commit 382a978.
bartlomieju added a commit that referenced this pull request Jan 31, 2022
@bartlomieju
Revert "refactor: factor out CDP message types (#13501)" (#13540)
b7b6b9c 
This reverts commit 382a978.
crowlKats added a commit to crowlKats/deno that referenced this pull request Jan 31, 2022
@crowlKats
refactor: factor out CDP message types (denoland#13501)
d61bf8e
@crowlKats crowlKats mentioned this pull request Feb 1, 2022
Merged
ry pushed a commit to ry/deno that referenced this pull request Feb 3, 2022
@bartlomieju @ry
Revert "refactor: factor out CDP message types (denoland#13501)" (den…
b5bb071 
…oland#13540)

This reverts commit 382a978.
ry pushed a commit to ry/deno that referenced this pull request Feb 3, 2022
@bartlomieju @ry
Revert "refactor: factor out CDP message types (denoland#13501)" (den…
6947f68 
…oland#13540)

This reverts commit 382a978.
bartlomieju added a commit that referenced this pull request Feb 3, 2022
@bartlomieju
Revert "refactor: factor out CDP message types (#13501)" (#13540)
20c1ed2 
This reverts commit 382a978.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@lucacasonato lucacasonato lucacasonato approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crowlKats @bartlomieju @ry @lucacasonato