refactor(repl): move rustyline sync channel communication into struct #12900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticed #12899 I can wait until after that PR is merged to merge this one cc @lucacasonato Edit: Actually, looks like that one requires a serde release. |
bartlomieju
approved these changes
Nov 25, 2021
lucacasonato
pushed a commit
to lucacasonato/deno
that referenced
this pull request
Dec 3, 2021
lucacasonato
pushed a commit
to lucacasonato/deno
that referenced
this pull request
Dec 3, 2021
lucacasonato
pushed a commit
that referenced
this pull request
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extracted this out of the repl import specifier autocompletion PR I'm working on.
Basically, for that PR I'm going to have to also get messages from the LSP for autocompletion and it would get out of hand quickly to not extract this out.