Revert "feat(ext/ffi): add support for buffer arguments (#12335)" #12343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 3faf75a.
I'm against reverting for that reason.
We can revert for that reason, or we can fix the bug, at your discretion. |
piscisaureus
previously approved these changes
Oct 6, 2021
piscisaureus
dismissed
their stale review
Actually please just fix the bug with multiple buffers.
|
Actually there is no bug, I added a test for good measure anyway (#12373). Closing without merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3faf75a.
Ref #12335
Reverting due to #12341, plus I found a bug when handling multiple buffers