Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/crypto): decode id-RSASSA-PSS with default params #12147

Merged
merged 5 commits into from
Oct 1, 2021
Merged

fix(ext/crypto): decode id-RSASSA-PSS with default params #12147

merged 5 commits into from
Oct 1, 2021

Conversation

littledivy
Copy link
Member

Keys with missing (default) parameters are now decodable. Example AlgorithmIdentifer:

SEQUENCE (2 elem)
    OBJECT IDENTIFIER 1.2.840.113549.1.1.10 rsaPSS (PKCS #1)
    SEQUENCE (1 elem)
      [2] (1 elem)
        INTEGER 30

bartlomieju
bartlomieju approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Divy!

@bartlomieju bartlomieju merged commit c0b6c0e into denoland:main Oct 1, 2021
@littledivy littledivy deleted the rsa_pss_params branch October 1, 2021 09:32
ry pushed a commit that referenced this pull request Oct 4, 2021
@littledivy @ry
fix(ext/crypto): decode id-RSASSA-PSS with default params (#12147)
586d869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@littledivy @bnoordhuis @bartlomieju