feat(cli): include markdown documents with test --doc #11421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
commented
Jul 16, 2021
caspervonb
changed the title
caspervonb
commented
Jul 18, 2021
…nb/deno into feat-cli-support-markdown-tests
…nb/deno into feat-cli-support-markdown-tests
bartlomieju
reviewed
Jul 26, 2021
bartlomieju
reviewed
Jul 26, 2021
cli/tools/test_runner.rs
Outdated
Comment on lines
355
to
389
| let parsed_module = | ||
| ast::parse(&file.specifier.as_str(), &file.source, &file.media_type)?; | ||
|
|
||
| let mut comments = parsed_module.get_comments(); | ||
| comments.sort_by_key(|comment| { | ||
| let location = parsed_module.get_location(&comment.span); | ||
| location.line | ||
| }); | ||
|
|
||
| let blocks_regex = Regex::new(r"```([^\n]*)\n([\S\s]*?)```")?; | ||
| let lines_regex = Regex::new(r"(?:\* ?)(?:\# ?)?(.*)")?; | ||
|
|
||
| for comment in comments { | ||
| if comment.kind != CommentKind::Block || !comment.text.starts_with('*') { | ||
| continue; | ||
| } | ||
|
|
||
| for block in blocks_regex.captures_iter(&comment.text) { | ||
| let maybe_attributes = block.get(1).map(|m| m.as_str().split(' ')); | ||
| let media_type = if let Some(mut attributes) = maybe_attributes { | ||
| match attributes.next() { | ||
| Some("js") => MediaType::JavaScript, | ||
| Some("jsx") => MediaType::Jsx, | ||
| Some("ts") => MediaType::TypeScript, | ||
| Some("tsx") => MediaType::Tsx, | ||
| Some("") => file.media_type, | ||
| _ => MediaType::Unknown, | ||
| } | ||
| } else { | ||
| file.media_type | ||
| }; | ||
|
|
||
| if media_type == MediaType::Unknown { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
There's a lot of duplication in programs_from_fenced_blocks; could you extract some helpers?
There was a problem hiding this comment.
I've rewritten it to be less awful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11170